third_party/WebKit/Source/modules/credentialmanager/SiteBoundCredential.idl - Issue 1880393002: CREDENTIAL: Implement 'SiteBoundCredential'.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/credentialmanager/SiteBoundCredential.idl

Issue 1880393002: CREDENTIAL: Implement 'SiteBoundCredential'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.idl ('K') | « third_party/WebKit/Source/modules/credentialmanager/SiteBoundCredential.cpp ('k') | third_party/WebKit/Source/modules/modules.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://w3c.github.io/webappsec-credential-management/#siteboundcredential

	6

	7 [

	8 RuntimeEnabled=CredentialManager,

	9 Exposed=Window

	10 ] interface SiteBoundCredential : Credential {

	11 readonly attribute DOMString name;
	philipj_slow 2016/04/19 09:20:37 Spec says USVString for both of these. I shouldn't Spec says USVString for both of these. I shouldn't change the generated code I think. At first I wondered why name isn't just DOMString in the spec, but then I felt like we've talked about this before and all of these things might end up serialized in a URL or some context where it's nice to not have to deal with bare surrogates. Right? Mike West 2016/04/25 10:20:13 Hrm. No. `name` should be a DOMString. iconURL is Show quoted text On 2016/04/19 at 09:20:37, philipj_slow wrote: > Spec says USVString for both of these. I shouldn't change the generated code I think. > > At first I wondered why name isn't just DOMString in the spec, but then I felt like we've talked about this before and all of these things might end up serialized in a URL or some context where it's nice to not have to deal with bare surrogates. Right? Hrm. No. `name` should be a DOMString. iconURL is a URL, and should be a USVString. I'll update this file and the spec: https://github.com/w3c/webappsec-credential-management/issues/14 (and Anne just told me that I'm wrong. So, changing all of it to USVString. :) ) philipj_slow 2016/04/25 11:54:21 OK, so USVString "for things that get utf-8 encode Show quoted text On 2016/04/25 10:20:13, Mike West (slow until 25th) wrote: > On 2016/04/19 at 09:20:37, philipj_slow wrote: > > Spec says USVString for both of these. I shouldn't change the generated code I > think. > > > > At first I wondered why name isn't just DOMString in the spec, but then I felt > like we've talked about this before and all of these things might end up > serialized in a URL or some context where it's nice to not have to deal with > bare surrogates. Right? > > Hrm. No. `name` should be a DOMString. iconURL is a URL, and should be a > USVString. I'll update this file and the spec: > https://github.com/w3c/webappsec-credential-management/issues/14 (and Anne just > told me that I'm wrong. So, changing all of it to USVString. :) ) OK, so USVString "for things that get utf-8 encoded" makes sense, not specifically serialization for URLs.
	12 readonly attribute DOMString iconURL;

	13 };

OLD	NEW