Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1880353004: PaymentRequest should be a ContextLifecycleObserver (Closed)

Created:
4 years, 8 months ago by rwlbuis
Modified:
4 years, 8 months ago
CC:
chromium-reviews, blink-reviews, Marijn Kruisselbrink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PaymentRequest should be a ContextLifecycleObserver This CL makes PaymentRequest a ContextLifecycleObserver. Since mojo::Binding::Close() has a precondition that it is bound, check that in PaymentRequest::cleanUp before calling Close(), if not Payment unit tests that create PaymentRequests that do not bind will crash. BUG=602660 Committed: https://crrev.com/5b76c04ae3040e16d924495416b722b2fcf13616 Cr-Commit-Position: refs/heads/master@{#387214}

Patch Set 1 #

Patch Set 2 : V2 #

Total comments: 6

Patch Set 3 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M third_party/WebKit/Source/modules/payments/PaymentRequest.h View 4 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 2 4 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
rwlbuis
PaymentRequest should be a ContextLifecycleObserver BUG=587995
4 years, 8 months ago (2016-04-13 17:41:49 UTC) #1
rwlbuis
PTAL.
4 years, 8 months ago (2016-04-13 19:12:16 UTC) #5
please use gerrit instead
https://codereview.chromium.org/1880353004/diff/20001/mojo/public/cpp/bindings/binding.h File mojo/public/cpp/bindings/binding.h (right): https://codereview.chromium.org/1880353004/diff/20001/mojo/public/cpp/bindings/binding.h#newcode159 mojo/public/cpp/bindings/binding.h:159: void Close() { if (internal_state_.is_bound()) internal_state_.Close(); } Instead of ...
4 years, 8 months ago (2016-04-13 22:56:46 UTC) #7
rwlbuis
https://codereview.chromium.org/1880353004/diff/20001/mojo/public/cpp/bindings/binding.h File mojo/public/cpp/bindings/binding.h (right): https://codereview.chromium.org/1880353004/diff/20001/mojo/public/cpp/bindings/binding.h#newcode159 mojo/public/cpp/bindings/binding.h:159: void Close() { if (internal_state_.is_bound()) internal_state_.Close(); } On 2016/04/13 ...
4 years, 8 months ago (2016-04-14 00:28:33 UTC) #8
please use gerrit instead
lgtm
4 years, 8 months ago (2016-04-14 00:33:30 UTC) #9
please use gerrit instead
> It > also changes mojo::Binding::Close() to only close the > message pipe if it ...
4 years, 8 months ago (2016-04-14 00:34:53 UTC) #10
rwlbuis
On 2016/04/14 00:34:53, Rouslan wrote: > > It > > also changes mojo::Binding::Close() to only ...
4 years, 8 months ago (2016-04-14 00:43:18 UTC) #12
haraken
LGTM, nice fix.
4 years, 8 months ago (2016-04-14 01:47:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880353004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880353004/40001
4 years, 8 months ago (2016-04-14 01:53:19 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-14 02:41:50 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 02:43:17 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5b76c04ae3040e16d924495416b722b2fcf13616
Cr-Commit-Position: refs/heads/master@{#387214}

Powered by Google App Engine
This is Rietveld 408576698