Fix TextAutosizer not to scheduleRelayout() for LayoutGrid::layoutBlock()

Fix TextAutosizer not to scheduleRelayout() for LayoutGrid::layoutBlock()

This patch fixes TextAutosizer not to scheduleRelayout() when it's
called from LayoutGrid::layoutBlock().

SubtreeLayoutScope was added in the same way as
LayoutFlexibleBox::layoutBlock() does, which is passed to TextAutosizer
to prevent it to call scheduleRelayout().

BUG=602908
Committed: https://crrev.com/8c2ad01a12f64788bacfc2c57125d3857a2b8e26
Cr-Commit-Position: refs/heads/master@{#387118}

[kojii, 2016-04-13 18:38:49]

Description was changed from

==========
grid-textautosizer

BUG=
==========

to

==========
Fix TextAutosizer not to scheduleRelayout() for LayoutGrid::layoutBlock()

This patch fixes TextAutosizer not to scheduleRelayout() when it's
called from LayoutGrid::layoutBlock().

SubtreeLayoutScope was added in the same way as
LayoutFlexibleBox::layoutBlock() does, which is passed to TextAutosizer
to prevent it to call scheduleRelayout().

BUG=602908
==========

[kojii, 2016-04-13 18:47:20]

kojii@chromium.org changed reviewers:
+ cbiesinger@chromium.org, svillar@igalia.com

[kojii, 2016-04-13 18:47:21]

PTAL.

I know little-to-no on LayoutGrid, but I'm working on fixing TextAutosizer to
scheduleRelayout() which can lead to crashes.

One way to prevent TextAutosizer to scheduleRelayout() is to give
SubtreeLayoutScope, and since LayoutFlexbox does this, I simply assumed we can
do the same to LayoutGrid.

The tests pass (win failure doesn't seem to be related), but if adding
SubtreeLayoutScope does not look right, I can change TextAutosizer to not to
scheduleRelayout() without SubtreeLayoutScope.

Using SubtreeLayoutScope is preferred however, so your reviews would be greatly
appreciated.

[cbiesinger, 2016-04-13 18:58:02]

lgtm. Grid uses SubtreeLayoutScope in a weird way, it really should have just
one throughout layout and pass it around but currently it litters them
throughout its methods. But that's a longer-term fix

[kojii, 2016-04-13 20:04:04]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2016-04-13 20:04:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880343004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880343004/1

[commit-bot: I haz the power, 2016-04-13 22:16:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-13 22:17:40]

Description was changed from

==========
Fix TextAutosizer not to scheduleRelayout() for LayoutGrid::layoutBlock()

This patch fixes TextAutosizer not to scheduleRelayout() when it's
called from LayoutGrid::layoutBlock().

SubtreeLayoutScope was added in the same way as
LayoutFlexibleBox::layoutBlock() does, which is passed to TextAutosizer
to prevent it to call scheduleRelayout().

BUG=602908
==========

to

==========
Fix TextAutosizer not to scheduleRelayout() for LayoutGrid::layoutBlock()

This patch fixes TextAutosizer not to scheduleRelayout() when it's
called from LayoutGrid::layoutBlock().

SubtreeLayoutScope was added in the same way as
LayoutFlexibleBox::layoutBlock() does, which is passed to TextAutosizer
to prevent it to call scheduleRelayout().

BUG=602908

Committed: https://crrev.com/8c2ad01a12f64788bacfc2c57125d3857a2b8e26
Cr-Commit-Position: refs/heads/master@{#387118}
==========

[commit-bot: I haz the power, 2016-04-13 22:17:41]

Patchset 1 (id:??) landed as
https://crrev.com/8c2ad01a12f64788bacfc2c57125d3857a2b8e26
Cr-Commit-Position: refs/heads/master@{#387118}