Use a token to initialise ChannelMojo and MojoApplication everywhere.

Use a token to initialise ChannelMojo and MojoApplication everywhere.

BUG=None

Committed: https://crrev.com/babb3f34fe20effb72c81104b63b2974271ad88d
Cr-Commit-Position: refs/heads/master@{#387161}

[Anand Mistry (off Chromium), 2016-04-13 01:13:40]

amistry@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-04-13 03:58:58]

Very nice. LGTM with optional change: WDYT about making MojoApplicationHost
retain a copy of its token instead of returning it from InitWithToken; then
adding an explicit method for passing the token out when needed? This would
obviate the need to introduce an additional token variable everywhere
MojoApplicationHost is used.

Also, can InitWithToken be implied by the constructor perhaps? Maybe not, but
just another thought.

[Anand Mistry (off Chromium), 2016-04-13 04:29:27]

On 2016/04/13 03:58:58, Ken Rockot wrote:
> Very nice. LGTM with optional change: WDYT about making MojoApplicationHost
> retain a copy of its token instead of returning it from InitWithToken; then
> adding an explicit method for passing the token out when needed? This would
> obviate the need to introduce an additional token variable everywhere
> MojoApplicationHost is used.

Done, except in one test place just to keep it simple.

> Also, can InitWithToken be implied by the constructor perhaps? Maybe not, but
> just another thought.

Good idea. Done.

[Anand Mistry (off Chromium), 2016-04-13 04:32:50]

amistry@chromium.org changed reviewers:
+ avi@chromium.org, tsepez@chromium.org

[Anand Mistry (off Chromium), 2016-04-13 04:32:51]

tsepez: For ChromeIPC related files.
avi: For content.

[Anand Mistry (off Chromium), 2016-04-13 07:17:52]

The CQ bit was checked by amistry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 07:18:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880343002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880343002/60001

[commit-bot: I haz the power, 2016-04-13 08:19:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 08:19:39]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-04-13 17:26:43]

lgtm

[Avi (use Gerrit), 2016-04-13 17:57:52]

lgtm

content stampity stamp

[Anand Mistry (off Chromium), 2016-04-13 22:10:50]

The CQ bit was checked by amistry@chromium.org

[Anand Mistry (off Chromium), 2016-04-13 22:10:50]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1880343002/#ps60001
(title: "Review comments.")

[commit-bot: I haz the power, 2016-04-13 22:11:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880343002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880343002/60001

[commit-bot: I haz the power, 2016-04-13 22:20:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 22:20:42]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Anand Mistry (off Chromium), 2016-04-13 22:44:40]

The CQ bit was checked by amistry@chromium.org

[Anand Mistry (off Chromium), 2016-04-13 22:44:40]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org, avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1880343002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-04-13 22:45:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880343002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880343002/80001

[commit-bot: I haz the power, 2016-04-14 00:03:06]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-14 00:04:52]

Description was changed from

==========
Use a token to initialise ChannelMojo and MojoApplication everywhere.

BUG=None
==========

to

==========
Use a token to initialise ChannelMojo and MojoApplication everywhere.

BUG=None

Committed: https://crrev.com/babb3f34fe20effb72c81104b63b2974271ad88d
Cr-Commit-Position: refs/heads/master@{#387161}
==========

[commit-bot: I haz the power, 2016-04-14 00:04:54]

Patchset 5 (id:??) landed as
https://crrev.com/babb3f34fe20effb72c81104b63b2974271ad88d
Cr-Commit-Position: refs/heads/master@{#387161}

[shrike, 2016-04-14 21:45:18]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1891043002/ by shrike@chromium.org.

The reason for reverting is: Suspecting for https://crbug.com/603452. We need to
see if reverting this patch fixes tomorrow's Mac Canary. If the problem persists
then this cl is not to blame and can be relanded..