components/crash/content/tools/generate_breakpad_symbols.py - Issue 1880333002: Use is_valid_dump to check for valid dumps in telemetry exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/content/tools/generate_breakpad_symbols.py

Issue 1880333002: Use is_valid_dump to check for valid dumps in telemetry exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable windows for testValidDump Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/crash/content/tools/generate_breakpad_symbols.py

diff --git a/components/crash/content/tools/generate_breakpad_symbols.py b/components/crash/content/tools/generate_breakpad_symbols.py

index e91a8c44252927495164482ed690b09b36793c02..b4c3b48a7002ed0e3ff0edadc15e9c6683659e9b 100755

--- a/components/crash/content/tools/generate_breakpad_symbols.py

+++ b/components/crash/content/tools/generate_breakpad_symbols.py

@@ -146,7 +146,7 @@ def mkdir_p(path):

def GetBinaryInfoFromHeaderInfo(header_info):

"""Given a standard symbol header information line, returns BINARY_INFO."""

# header info is of the form "MODULE $PLATFORM $ARCH $HASH $BINARY"

- info_split = header_info.strip().split(' ', 5)

+ info_split = header_info.strip().split(' ', 4)

if len(info_split) != 5 or info_split[0] != 'MODULE':

return None

return BINARY_INFO(*info_split[1:])

« no previous file with comments | « no previous file | tools/perf/core/stacktrace_unittest.py » ('j') | no next file with comments »