Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 188033005: Have Position deal with more references (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
adamk
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis
Visibility:
Public.

Description

Have Position deal with more references Have Position deal with more references instead of pointers. This makes the code look safer. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168675

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -94 lines) Patch
M Source/core/dom/Position.h View 4 chunks +10 lines, -14 lines 0 comments Download
M Source/core/dom/Position.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
M Source/core/dom/PositionIterator.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/ApplyBlockElementCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 4 chunks +6 lines, -5 lines 0 comments Download
M Source/core/editing/BreakBlockquoteCommand.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/FormatBlockCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/IndentOutdentCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/InsertLineBreakCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/InsertListCommand.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/TextIterator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/TypingCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/htmlediting.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/markup.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 9 months ago (2014-03-06 01:55:37 UTC) #1
adamk
lgtm
6 years, 9 months ago (2014-03-06 20:36:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/188033005/1
6 years, 9 months ago (2014-03-06 20:36:55 UTC) #3
commit-bot: I haz the power
Change committed as 168675
6 years, 9 months ago (2014-03-06 20:48:36 UTC) #4
Inactive
6 years, 9 months ago (2014-03-10 19:17:21 UTC) #5
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/189773005/ by ch.dumez@samsung.com.

The reason for reverting is: null can be passed to positionAfterNode() so we
cannot make the argument a reference.
See crbug.com/350968..

Powered by Google App Engine
This is Rietveld 408576698