Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1880323002: dart2js cleanup: remove unused imports and variables (Closed)

Created:
4 years, 8 months ago by Harry Terkelsen
Modified:
4 years, 8 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cleanup: remove unused imports and variables BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/01e839c732fe68cca14c5430e166b0931b3e463e

Patch Set 1 #

Patch Set 2 : merge master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -441 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 1 1 chunk +5 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/common/registry.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 3 chunks +7 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/constants/constructors.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/constants/values.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 3 chunks +15 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/inline.dart View 1 1 chunk +10 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_mask_system.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 chunk +6 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/dart_types.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 2 chunks +3 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 3 chunks +5 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 1 chunk +5 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 1 chunk +9 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 2 chunks +3 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/info/send_info.dart View 5 chunks +3 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/io/position_information.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/io/source_information.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/io/start_end_information.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js/js.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js/js_source_mapping.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 chunk +6 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 6 chunks +10 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_interop_analysis.dart View 2 chunks +2 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 2 chunks +4 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 3 chunks +8 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 4 chunks +2 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart View 2 chunks +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/model.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 4 chunks +14 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/native/scanner.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/native/ssa.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/member_listener.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 3 chunks +2 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 1 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 4 chunks +3 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/impact_serialization.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/serialization/serialization_util.dart View 1 chunk +1 line, -6 lines 0 comments Download
M pkg/compiler/lib/src/source_file_provider.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 6 chunks +5 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 3 chunks +3 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/types_propagation.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/value_range_analyzer.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/tree/prettyprint.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree/unparser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 3 chunks +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/call_structure.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_impact.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/samples/darttags/darttags.dart View 1 chunk +3 lines, -7 lines 0 comments Download
M pkg/compiler/samples/jsonify/jsonify.dart View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Harry Terkelsen
4 years, 8 months ago (2016-04-12 22:40:46 UTC) #2
Johnni Winther
LGTM
4 years, 8 months ago (2016-04-13 07:35:22 UTC) #3
Harry Terkelsen
4 years, 8 months ago (2016-04-13 16:11:45 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
01e839c732fe68cca14c5430e166b0931b3e463e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698