Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1880313003: Mac File Dialogs: Remove SaveAccessoryView.xib (Closed)

Created:
4 years, 8 months ago by karandeepb
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac File Dialogs: Remove SaveAccessoryView.xib This CL removes SaveAccessoryView.xib and replaces it with a programmatically created accessory view for file dialogs on Mac. This CL leads to the following UI changes - - The popup button in the accessory view is now only as wide as the content. - The accessory view now lays out correctly in RTL mode. This CL also fixes the warnings that were displayed on running shell_dialog_unittests on Mac. BUG=603303, 596830

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -72 lines) Patch
M base/mac/sdk_forward_declarations.h View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/app/nibs/SaveAccessoryView.xib View 1 1 chunk +0 lines, -54 lines 0 comments Download
M chrome/chrome_nibs.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
A ui/shell_dialogs/Todo: add gn target shell_dialogs_unittests View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M ui/shell_dialogs/run_all_unittests.cc View 1 2 3 4 5 2 chunks +0 lines, -9 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_mac.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_mac.mm View 1 2 3 4 5 6 5 chunks +35 lines, -4 lines 0 comments Download
M ui/shell_dialogs/shell_dialogs.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/strings/ui_strings.grd View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (3 generated)
karandeepb
Description was changed from ========== ----- BUG= ========== to ========== Mac File Dialogs: Remove SaveAccessoryView.xib ...
4 years, 8 months ago (2016-04-14 03:46:18 UTC) #1
karandeepb
Description was changed from ========== Mac File Dialogs: Remove SaveAccessoryView.xib This CL removes SaveAccessoryView.xib and ...
4 years, 8 months ago (2016-04-14 03:47:16 UTC) #2
karandeepb
4 years, 8 months ago (2016-04-14 03:48:18 UTC) #3 
Description was changed from

==========
Mac File Dialogs: Remove SaveAccessoryView.xib

This CL removes SaveAccessoryView.xib and replaces it with a programmitcally 
created accessory view for file dialogs on Mac. This CL leads to the following 
UI changes - 
  - The popup button in the accessory view is now only as wide as the content.
  - The accessory view now lays out correctly in RTL mode.

This CL also fixes the warnings that were displayed on running 
shell_dialog_unittests on Mac.

BUG=603303,596830
==========

to

==========
Mac File Dialogs: Remove SaveAccessoryView.xib

This CL removes SaveAccessoryView.xib and replaces it with a programmatically 
created accessory view for file dialogs on Mac. This CL leads to the following 
UI changes - 
  - The popup button in the accessory view is now only as wide as the content.
  - The accessory view now lays out correctly in RTL mode.

This CL also fixes the warnings that were displayed on running 
shell_dialog_unittests on Mac.

BUG=603303,596830
==========

Powered by Google App Engine
This is Rietveld 408576698