Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1880243004: aw: Ensure WebView stays alive until functor detach (Closed)

Created:
4 years, 8 months ago by boliu
Modified:
4 years, 8 months ago
Reviewers:
Tobias Sargeant
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Ensure WebView stays alive until functor detach Android will not guarantee that the WebView is not garbage colllected before functor detached is called. So we need to add a gc root while the functor detached callback is pending. BUG=597167 Committed: https://crrev.com/8e2e091e5c565b90e76ceb85dd4c848013c5cf94 Cr-Commit-Position: refs/heads/master@{#387071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 4 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
boliu
ptal
4 years, 8 months ago (2016-04-13 18:44:34 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880243004/1
4 years, 8 months ago (2016-04-13 18:44:55 UTC) #4
Tobias Sargeant
lgtm
4 years, 8 months ago (2016-04-13 19:10:41 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 19:36:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880243004/1
4 years, 8 months ago (2016-04-13 19:44:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 19:51:05 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8e2e091e5c565b90e76ceb85dd4c848013c5cf94 Cr-Commit-Position: refs/heads/master@{#387071}
4 years, 8 months ago (2016-04-13 19:52:29 UTC) #12
boliu
4 years, 8 months ago (2016-04-15 23:56:05 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1897583002/ by boliu@chromium.org.

The reason for reverting is: API changed.

Powered by Google App Engine
This is Rietveld 408576698