Revert of build: Enable complex class copy ctor check by default.

Revert of build: Enable complex class copy ctor check by default. (patchset #4 id:60001 of https://codereview.chromium.org/1826693002/ )

Reason for revert:
This breaks win_clang

Original issue's description:
> build: Enable complex class copy ctor check by default.
>
> This patch ensures that our FindBadConstructs plugin starts detecting
> when a complex class requires an out of line copy constructor.
>
> R=thakis@chromium.org, dcheng@chromium.org
> BUG=436357
>
> Committed: https://crrev.com/319a17cb9761369818c8d8405da8d65c0a8bbc22
> Cr-Commit-Position: refs/heads/master@{#386787}

TBR=jochen@chromium.org,dcheng@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=436357
Committed: https://crrev.com/6a8849450d8ba833451921eee4adb2b1a1f4d84b
Cr-Commit-Position: refs/heads/master@{#386794}

[vmpstr, 2016-04-12 20:26:26]

Created Revert of build: Enable complex class copy ctor check by default.

[commit-bot: I haz the power, 2016-04-12 20:27:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880243002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880243002/1

[commit-bot: I haz the power, 2016-04-12 20:27:46]

Committed patchset #1 (id:1)

[Nico, 2016-04-12 20:28:42]

thanks!

you could enable the check on non-win first to make sure most of the codebase
doesn't regress, and enable it on win a bit later

[commit-bot: I haz the power, 2016-04-12 20:29:21]

Description was changed from

==========
Revert of build: Enable complex class copy ctor check by default. (patchset #4
id:60001 of https://codereview.chromium.org/1826693002/ )

Reason for revert:
This breaks win_clang

Original issue's description:
> build: Enable complex class copy ctor check by default.
> 
> This patch ensures that our FindBadConstructs plugin starts detecting
> when a complex class requires an out of line copy constructor.
> 
> R=thakis@chromium.org, dcheng@chromium.org
> BUG=436357
> 
> Committed: https://crrev.com/319a17cb9761369818c8d8405da8d65c0a8bbc22
> Cr-Commit-Position: refs/heads/master@{#386787}

TBR=jochen@chromium.org,dcheng@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=436357
==========

to

==========
Revert of build: Enable complex class copy ctor check by default. (patchset #4
id:60001 of https://codereview.chromium.org/1826693002/ )

Reason for revert:
This breaks win_clang

Original issue's description:
> build: Enable complex class copy ctor check by default.
>
> This patch ensures that our FindBadConstructs plugin starts detecting
> when a complex class requires an out of line copy constructor.
>
> R=thakis@chromium.org, dcheng@chromium.org
> BUG=436357
>
> Committed: https://crrev.com/319a17cb9761369818c8d8405da8d65c0a8bbc22
> Cr-Commit-Position: refs/heads/master@{#386787}

TBR=jochen@chromium.org,dcheng@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=436357

Committed: https://crrev.com/6a8849450d8ba833451921eee4adb2b1a1f4d84b
Cr-Commit-Position: refs/heads/master@{#386794}
==========

[commit-bot: I haz the power, 2016-04-12 20:29:22]

Patchset 1 (id:??) landed as
https://crrev.com/6a8849450d8ba833451921eee4adb2b1a1f4d84b
Cr-Commit-Position: refs/heads/master@{#386794}

[vmpstr, 2016-04-12 20:35:19]

On 2016/04/12 20:28:42, Nico wrote:
> thanks!
> 
> you could enable the check on non-win first to make sure most of the codebase
> doesn't regress, and enable it on win a bit later

I'm going to quickly see if there's a lot of changes that need to happen for
win. If it's not too bad, I'll just fix the win_clang. Do you know if there are
any other bots to watch out for that aren't run as a typical CQ set?

[Nico, 2016-04-12 20:36:12]

The android/clang trybot builds with asan=1 set, so regular android/clang
builds aren't tested. This usually isn't a problem in practice though.

On Tue, Apr 12, 2016 at 4:35 PM, <vmpstr@chromium.org> wrote:

> On 2016/04/12 20:28:42, Nico wrote:
> > thanks!
> >
> > you could enable the check on non-win first to make sure most of the
> codebase
> > doesn't regress, and enable it on win a bit later
>
> I'm going to quickly see if there's a lot of changes that need to happen
> for
> win. If it's not too bad, I'll just fix the win_clang. Do you know if
> there are
> any other bots to watch out for that aren't run as a typical CQ set?
>
> https://codereview.chromium.org/1880243002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.