Remove unconditionally set "--no-proxy-server" browser flag.

Remove unconditionally set "--no-proxy-server" browser flag.

BUG=349589
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255309

[bolian, 2014-03-05 21:47:05]

I simply removed the line. We have another place setting it based on options a
few lines below:

    if self.browser_options.no_proxy_server:
      args.append('--no-proxy-server')

It seems no test depends on this, but I could be wrong.

[tonyg, 2014-03-05 21:54:08]

Can you please blame that line and read the CL/bug that added it? IIRC, we added
it to work around a really hard to diagnose issue on XP. I assume you want the
flag gone for data compression proxy testing. Can we detect somehow whether we
are testing data compression proxy and only disable the flag in that case? Or
maybe you can confirm that the original issue is no longer relevant?

[bolian, 2014-03-05 22:01:02]

I see. It was https://chromiumcodereview.appspot.com/23061006
I think I will add an option to force enabling it for the data compression proxy
cases then.
Thanks!

[bolian, 2014-03-06 00:18:39]

I now checks the existence of data reduction proxy flag,
'--enable-spdy-proxy-auth' and then set '--no-proxy-server'.

Please take another look, thanks!

[tonyg, 2014-03-06 00:24:42]

lgtm

[bolian, 2014-03-06 00:50:06]

The CQ bit was checked by bolian@chromium.org

[commit-bot: I haz the power, 2014-03-06 00:52:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bolian@chromium.org/188023003/40001

[commit-bot: I haz the power, 2014-03-06 02:23:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 02:23:38]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[bolian, 2014-03-06 02:32:37]

The CQ bit was checked by bolian@chromium.org

[commit-bot: I haz the power, 2014-03-06 02:52:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bolian@chromium.org/188023003/40001

[commit-bot: I haz the power, 2014-03-06 03:17:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bolian@chromium.org/188023003/40001

[commit-bot: I haz the power, 2014-03-06 10:57:25]

Change committed as 255309