chrome/common/extensions/api/system_indicator/system_indicator_handler.cc - Issue 1880143002: Convert chrome/common to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/system_indicator/system_indicator_handler.cc

Issue 1880143002: Convert chrome/common to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/storage/storage_schema_manifest_handler.cc ('k') | chrome/common/extensions/api/url_handlers/url_handlers_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/system_indicator/system_indicator_handler.cc

diff --git a/chrome/common/extensions/api/system_indicator/system_indicator_handler.cc b/chrome/common/extensions/api/system_indicator/system_indicator_handler.cc

index 6ce19dcdd82be34fe3b21b8ac1f96477f4a61ccb..571d155049944cc33a5fc440919a519d89bb12fe 100644

--- a/chrome/common/extensions/api/system_indicator/system_indicator_handler.cc

+++ b/chrome/common/extensions/api/system_indicator/system_indicator_handler.cc

@@ -4,7 +4,8 @@

#include "chrome/common/extensions/api/system_indicator/system_indicator_handler.h"

-#include "base/memory/scoped_ptr.h"

+#include <memory>

#include "base/strings/utf_string_conversions.h"

#include "base/values.h"

#include "chrome/common/extensions/api/extension_action/action_info.h"

@@ -28,8 +29,8 @@ bool SystemIndicatorHandler::Parse(Extension* extension,

return false;

}

- scoped_ptr<ActionInfo> action_info = ActionInfo::Load(

- extension, system_indicator_value, error);

+ std::unique_ptr<ActionInfo> action_info =

+ ActionInfo::Load(extension, system_indicator_value, error);

if (!action_info.get())

return false;