Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 188013003: Make missing PRESUBMIT.py warning consistent with others. (Closed)

Created:
6 years, 9 months ago by mdempsky
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Make missing PRESUBMIT.py warning consistent with others. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=255125

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M presubmit_support.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
mdempsky
All the other mentions of PRESUBMIT.py files call it that; this is the only place ...
6 years, 9 months ago (2014-03-05 19:37:06 UTC) #1
iannucci
lgtm
6 years, 9 months ago (2014-03-05 19:48:20 UTC) #2
mdempsky_google
The CQ bit was checked by mdempsky@google.com
6 years, 9 months ago (2014-03-05 19:51:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdempsky@chromium.org/188013003/1
6 years, 9 months ago (2014-03-05 19:51:40 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 19:55:57 UTC) #5
Message was sent while issue was closed.
Change committed as 255125

Powered by Google App Engine
This is Rietveld 408576698