Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 18801015: WebCrypto: Update the key usage names to reflect recent changes to the spec. (Closed)

Created:
7 years, 5 months ago by eroman
Modified:
7 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, eae+blinkwatch, dglazkov+blink, tommyw+watchlist_chromium.org, jeez, Ryan Sleevi
Visibility:
Public.

Description

WebCrypto: Update the key usage names to reflect recent changes to the spec. keyUsage --> usages "derive" --> "deriveKey" "wrap" --> "wrapKey" "unwrap" --> "unwrapKey" This corresponds with: https://dvcs.w3.org/hg/webcrypto-api/rev/f5734f8b2e6a https://dvcs.w3.org/hg/webcrypto-api/rev/ec111797d17a https://dvcs.w3.org/hg/webcrypto-api/rev/37f65665a51b BUG=245025 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153809

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M Source/core/platform/chromium/support/WebCryptoKey.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/modules/crypto/Key.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/Key.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/modules/crypto/Key.idl View 2 chunks +4 lines, -4 lines 0 comments Download
M public/platform/WebCryptoKey.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
eroman
7 years, 5 months ago (2013-07-09 00:36:40 UTC) #1
abarth-chromium
LGTM, but I'm sad that there aren't any tests yet...
7 years, 5 months ago (2013-07-09 01:20:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/18801015/1
7 years, 5 months ago (2013-07-09 01:54:36 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=12281
7 years, 5 months ago (2013-07-09 04:08:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/18801015/1
7 years, 5 months ago (2013-07-09 16:04:52 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=12400
7 years, 5 months ago (2013-07-09 17:35:11 UTC) #6
eroman
Adam, I don't want you to be sad :) What I can do is add ...
7 years, 5 months ago (2013-07-09 18:15:59 UTC) #7
abarth-chromium
On 2013/07/09 18:15:59, eroman wrote: > I'll whip together a changelist and see if you ...
7 years, 5 months ago (2013-07-09 18:35:45 UTC) #8
eroman
7 years, 5 months ago (2013-07-09 20:07:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r153809 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698