[Interpreter] Disables OSR for interpreted functions when called with %OptimizeOSR.

[Interpreter] Disables OSR for interpreted functions when called with %OptimizeOSR.

When %OptimizeOSR is used with ignition flag, the runtime function tries to
compile for OSR on interpreted functions. This cl modifies
Runtime_OptimizeOsr function to return false for interpreted frames.

BUG=v8:4280, chromium:599002
LOG=N

Committed: https://crrev.com/570c2a3237dabdeb36b4139d8f2150d4b289a247
Cr-Commit-Position: refs/heads/master@{#35421}

[mythria, 2016-04-12 11:03:18]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 11:03:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880073002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880073002/1

[mythria, 2016-04-12 11:04:02]

Description was changed from

==========
[Interpreter] Disables OSR for interpreted functions with %OptimizeOSR
intrinsic.

When %OptimizeOSR is used with ignition flag, the runtime function tries to
compile for OSR on interpreted functions. This cl modifies
IsSuitableForOnStackReplacement function to return false for interpreted frames.

BUG=v8:4280,chromium:599002
LOG=N
==========

to

==========
[Interpreter] Disables OSR for interpreted functions when called with
%OptimizeOSR.

When %OptimizeOSR is used with ignition flag, the runtime function tries to
compile for OSR on interpreted functions. This cl modifies
IsSuitableForOnStackReplacement function to return false for interpreted frames.

BUG=v8:4280,chromium:599002
LOG=N
==========

[commit-bot: I haz the power, 2016-04-12 11:24:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 11:24:57]

Dry run: This issue passed the CQ dry run.

[mythria, 2016-04-12 11:38:11]

mythria@chromium.org changed reviewers:
+ mstarzinger@chromium.org, rmcilroy@chromium.org

[mythria, 2016-04-12 11:38:12]

This is to fix clusterfuzz bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=599002.

When we use %OptimizeOSR with ignition flag, we try to do OSR on interpreted
function and fail. I added a check to return false if the function is
interpreted. 

PTAL.

Thanks,
Mythri

[mythria, 2016-04-12 11:44:59]

Sorry, don't look at it yet. I think I fixed at the wrong place. Will upload
another patch and update.

[mythria, 2016-04-12 11:56:37]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 11:56:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880073002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880073002/20001

[mythria, 2016-04-12 11:57:55]

Description was changed from

==========
[Interpreter] Disables OSR for interpreted functions when called with
%OptimizeOSR.

When %OptimizeOSR is used with ignition flag, the runtime function tries to
compile for OSR on interpreted functions. This cl modifies
IsSuitableForOnStackReplacement function to return false for interpreted frames.

BUG=v8:4280,chromium:599002
LOG=N
==========

to

==========
[Interpreter] Disables OSR for interpreted functions when called with
%OptimizeOSR.

When %OptimizeOSR is used with ignition flag, the runtime function tries to
compile for OSR on interpreted functions. This cl modifies
Runtime_OptimizeOsr
function to return false for interpreted frames.

BUG=v8:4280,chromium:599002
LOG=N
==========

[mythria, 2016-04-12 11:58:15]

Description was changed from

==========
[Interpreter] Disables OSR for interpreted functions when called with
%OptimizeOSR.

When %OptimizeOSR is used with ignition flag, the runtime function tries to
compile for OSR on interpreted functions. This cl modifies
Runtime_OptimizeOsr
function to return false for interpreted frames.

BUG=v8:4280,chromium:599002
LOG=N
==========

to

==========
[Interpreter] Disables OSR for interpreted functions when called with
%OptimizeOSR.

When %OptimizeOSR is used with ignition flag, the runtime function tries to
compile for OSR on interpreted functions. This cl modifies
Runtime_OptimizeOsr function to return false for interpreted frames.

BUG=v8:4280,chromium:599002
LOG=N
==========

[commit-bot: I haz the power, 2016-04-12 12:17:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 12:17:03]

Dry run: This issue passed the CQ dry run.

[mythria, 2016-04-12 12:20:47]

PTAL. Uploaded the correct fix now :).

[Michael Starzinger, 2016-04-12 12:31:11]

LGTM.

[rmcilroy, 2016-04-12 12:56:56]

LGTM

https://codereview.chromium.org/1880073002/diff/20001/src/runtime/runtime-tes...
File src/runtime/runtime-test.cc (right):

https://codereview.chromium.org/1880073002/diff/20001/src/runtime/runtime-tes...
src/runtime/runtime-test.cc:138: // If funciton is interpreted, just return. OSR
is not supported.
/s/funciton/function.

[mythria, 2016-04-12 14:23:24]

Thanks for the review.

https://codereview.chromium.org/1880073002/diff/20001/src/runtime/runtime-tes...
File src/runtime/runtime-test.cc (right):

https://codereview.chromium.org/1880073002/diff/20001/src/runtime/runtime-tes...
src/runtime/runtime-test.cc:138: // If funciton is interpreted, just return. OSR
is not supported.
On 2016/04/12 12:56:56, rmcilroy wrote:
> /s/funciton/function.

Thanks, Done.

[mythria, 2016-04-12 14:23:32]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 14:23:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880073002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880073002/40001

[commit-bot: I haz the power, 2016-04-12 14:43:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 14:43:33]

Dry run: This issue passed the CQ dry run.

[mythria, 2016-04-12 15:22:51]

The CQ bit was checked by mythria@chromium.org

[mythria, 2016-04-12 15:22:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1880073002/#ps40001
(title: "Fixes a typo.")

[commit-bot: I haz the power, 2016-04-12 15:22:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880073002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880073002/40001

[commit-bot: I haz the power, 2016-04-12 15:24:54]

Description was changed from

==========
[Interpreter] Disables OSR for interpreted functions when called with
%OptimizeOSR.

When %OptimizeOSR is used with ignition flag, the runtime function tries to
compile for OSR on interpreted functions. This cl modifies
Runtime_OptimizeOsr function to return false for interpreted frames.

BUG=v8:4280,chromium:599002
LOG=N
==========

to

==========
[Interpreter] Disables OSR for interpreted functions when called with
%OptimizeOSR.

When %OptimizeOSR is used with ignition flag, the runtime function tries to
compile for OSR on interpreted functions. This cl modifies
Runtime_OptimizeOsr function to return false for interpreted frames.

BUG=v8:4280,chromium:599002
LOG=N
==========

[commit-bot: I haz the power, 2016-04-12 15:24:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-12 15:25:44]

Description was changed from

==========
[Interpreter] Disables OSR for interpreted functions when called with
%OptimizeOSR.

When %OptimizeOSR is used with ignition flag, the runtime function tries to
compile for OSR on interpreted functions. This cl modifies
Runtime_OptimizeOsr function to return false for interpreted frames.

BUG=v8:4280,chromium:599002
LOG=N
==========

to

==========
[Interpreter] Disables OSR for interpreted functions when called with
%OptimizeOSR.

When %OptimizeOSR is used with ignition flag, the runtime function tries to
compile for OSR on interpreted functions. This cl modifies
Runtime_OptimizeOsr function to return false for interpreted frames.

BUG=v8:4280,chromium:599002
LOG=N

Committed: https://crrev.com/570c2a3237dabdeb36b4139d8f2150d4b289a247
Cr-Commit-Position: refs/heads/master@{#35421}
==========

[commit-bot: I haz the power, 2016-04-12 15:25:45]

Patchset 3 (id:??) landed as
https://crrev.com/570c2a3237dabdeb36b4139d8f2150d4b289a247
Cr-Commit-Position: refs/heads/master@{#35421}