Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1880063002: Fix Closure errors. (Closed)

Created:
4 years, 8 months ago by Finnur
Modified:
4 years, 8 months ago
Reviewers:
Dan Beam, michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Closure errors. BUG=543635 TBR=michaelpg Committed: https://crrev.com/30763d52a823217b873b7ead2ba6462ef6f5f525 Cr-Commit-Position: refs/heads/master@{#386651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/resources/settings/site_settings/site_details_permission.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_list.js View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Finnur
4 years, 8 months ago (2016-04-12 10:34:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880063002/1
4 years, 8 months ago (2016-04-12 10:34:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 11:27:52 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/30763d52a823217b873b7ead2ba6462ef6f5f525 Cr-Commit-Position: refs/heads/master@{#386651}
4 years, 8 months ago (2016-04-12 11:29:25 UTC) #9
Dan Beam
this didn't work https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/52745/steps/compile_v2/logs/stdio
4 years, 8 months ago (2016-04-12 16:29:22 UTC) #11
Finnur
4 years, 8 months ago (2016-04-13 13:05:52 UTC) #12
Message was sent while issue was closed. 
It worked in the sense that it fixed the Closure errors that it was intended to
fix, but more appeared in the meantime. 

I was late in realizing that Closure wasn't being run because of the dependency
cycle problem, but both these new Closure errors and the cycle problem are under
control (CL in progress and using the --no-circular-check.

Powered by Google App Engine
This is Rietveld 408576698