[Android] Fix compilation error: unused variable 'kAllowedToAccessOnNonjoinableThread'

[Android] Fix compilation error: unused variable 'kAllowedToAccessOnNonjoinableThread'

While building with clang=1, clang reports this error about the above variable being unused.

BUG=349521
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255159

[vivekg, 2014-03-05 18:38:14]

PTAL, thank you!

[Nico, 2014-03-05 18:41:26]

https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/po...
<- this is a better approach I think

[Nico, 2014-03-05 18:43:33]

Looks like
https://code.google.com/p/chromium/codesearch#chromium/src/content/child/chil...
does this with UNUSED too, can you change that to the ifdef too while you're
here?

[vivekg, 2014-03-05 18:47:26]

On 2014/03/05 18:43:33, Nico wrote:
> Looks like
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/child/chil...
> does this with UNUSED too, can you change that to the ifdef too while you're
> here?

:) in-fact with Patch Set 1, I fixed it using this reference itself... Sure, I
will fix both these places. Thanks!

[vivekg, 2014-03-05 18:51:58]

Fixed as per the review comments. PTAL, thank you!

[Nico, 2014-03-05 18:55:05]

lgtm, thanks!

(+fischman fhi)

[vivekg, 2014-03-05 19:00:13]

On 2014/03/05 18:55:05, Nico wrote:
> lgtm, thanks!
> 
> (+fischman fhi)

Thank you @thakis. 

@fischman, if the change looks fine to you, can you please set the CQ bit for
this CL? (Bit late here in India: 1 AM, hence the request!)
Thank you.

[Nico, 2014-03-05 19:01:01]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-03-05 19:01:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/188003002/40001

[Nico, 2014-03-05 19:01:19]

On 2014/03/05 19:00:13, vivekg_ wrote:
> On 2014/03/05 18:55:05, Nico wrote:
> > lgtm, thanks!
> > 
> > (+fischman fhi)
> 
> Thank you @thakis. 
> 
> @fischman, if the change looks fine to you, can you please set the CQ bit for
> this CL? (Bit late here in India: 1 AM, hence the request!)
> Thank you.

<jedi-mindwave>This change looks fine to fischman</jedi-mindwave>

[Ami GONE FROM CHROMIUM, 2014-03-05 19:05:32]

On 2014/03/05 18:55:05, Nico wrote:
> lgtm, thanks!
> 
> (+fischman fhi)

Thanks for looping me in Nico.
I think #ifdef is the wrong approach here; these classes are "implementing" an
"interface" that is unconditionally specified (not only in !NDEBUG):
https://code.google.com/p/chromium/codesearch#chromium/src/base/memory/single...
Quotes above are for the fact that these aren't really a C++ class heirarchy,
but the flavor is the same so IMO omitting fields in "impls" b/c we know they
are only tested for in !NDEBUG is poor form.
Just sayin'.

[Ami GONE FROM CHROMIUM, 2014-03-05 19:06:07]

The CQ bit was unchecked by fischman@chromium.org

[Ami GONE FROM CHROMIUM, 2014-03-05 19:07:01]

Unchecked CQ box b/c I'm not the Weak-Minded Fool(tm) that thakis@ thinks I am.

@thakis: feel free to re-check if you strongly disagree; this smells like an
OWNERS decision to me.

[Nico, 2014-03-05 19:07:23]

On Wed, Mar 5, 2014 at 11:05 AM, <fischman@chromium.org> wrote:

> On 2014/03/05 18:55:05, Nico wrote:
>
>> lgtm, thanks!
>>
>
>  (+fischman fhi)
>>
>
> Thanks for looping me in Nico.
> I think #ifdef is the wrong approach here; these classes are
> "implementing" an
> "interface" that is unconditionally specified (not only in !NDEBUG):
> https://code.google.com/p/chromium/codesearch#chromium/
> src/base/memory/singleton.h&rcl=1393971344&l=66
> Quotes above are for the fact that these aren't really a C++ class
> heirarchy,
> but the flavor is the same so IMO omitting fields in "impls" b/c we know
> they
> are only tested for in !NDEBUG is poor form.
> Just sayin'.
>

I guess it could be ifdef'd in the interface too. The only use is in
!NDEBUG code.

Marking this used means there will be storage for the bool even though it's
not really used I believe.

(My mindwave powers are broken today :'-( )


>
> https://codereview.chromium.org/188003002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-03-05 19:08:58]

Can I OWNERS-decide to move the interface bool behind and !NDEBUG then? :-)


On Wed, Mar 5, 2014 at 11:07 AM, <fischman@chromium.org> wrote:

> Unchecked CQ box b/c I'm not the Weak-Minded Fool(tm) that thakis@ thinks
> I am.
>
> @thakis: feel free to re-check if you strongly disagree; this smells like
> an
> OWNERS decision to me.
>
> https://codereview.chromium.org/188003002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ami GONE FROM CHROMIUM, 2014-03-05 19:33:18]

On Wed, Mar 5, 2014 at 11:08 AM, Nico Weber <thakis@chromium.org> wrote:

> Can I OWNERS-decide to move the interface bool behind and !NDEBUG then? :-)
>

Sure.  That would ensure that nobody started depending on the field for
NDEBUG purposes.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-03-05 19:34:27]

Ok, then let's cq+ this again to unbreak builds, and i'll do the interface
in a follow-up later today. Thanks!


On Wed, Mar 5, 2014 at 11:33 AM, Ami Fischman <fischman@chromium.org> wrote:

>
> On Wed, Mar 5, 2014 at 11:08 AM, Nico Weber <thakis@chromium.org> wrote:
>
>> Can I OWNERS-decide to move the interface bool behind and !NDEBUG then?
>> :-)
>>
>
> Sure.  That would ensure that nobody started depending on the field for
> NDEBUG purposes.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ami GONE FROM CHROMIUM, 2014-03-05 19:35:56]

The CQ bit was checked by fischman@chromium.org

[commit-bot: I haz the power, 2014-03-05 19:36:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/188003002/40001

[Ami GONE FROM CHROMIUM, 2014-03-05 19:36:32]

On 2014/03/05 19:34:27, Nico wrote:
> Ok, then let's cq+ this again

Done.

> to unbreak builds, 

lol didn't realize this was unbreaking.

> and i'll do the interface
> in a follow-up later today. Thanks!

Thank _you_!

[Avi (use Gerrit), 2014-03-05 19:38:00]

LGTM

[commit-bot: I haz the power, 2014-03-05 21:40:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 21:40:49]

Try jobs failed on following builders: mac_chromium_rel

[Nico, 2014-03-05 21:53:09]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-03-05 21:56:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/188003002/40001

[commit-bot: I haz the power, 2014-03-05 21:58:40]

Change committed as 255159