Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1880003002: Added browser-side service for navigator.actions. (Closed)

Created:
4 years, 8 months ago by Matt Giuca
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ballista-share-requester-mojo-blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added browser-side service for navigator.actions. Currently just a stub (returns an error message). BUG=595608 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Patch Set 4 : Fix compile due to rebase. #

Patch Set 5 : Only add ShareService if experimental flag is on. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M content/browser/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
A content/browser/webshare/share_service_impl.h View 1 1 chunk +37 lines, -0 lines 0 comments Download
A content/browser/webshare/share_service_impl.cc View 1 1 chunk +31 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1806253002 Patch 770001

Dependent Patchsets:

Issue 1814133002 Patch 60001
Issue 1814133002 Patch 80001
Issue 1814133002 Patch 120001
Issue 1814133002 Patch 160001

Messages

Total messages: 7 (5 generated)
Matt Giuca
sammc: For initial review. Thanks!
4 years, 5 months ago (2016-07-21 08:07:11 UTC) #4
Matt Giuca
4 years, 5 months ago (2016-07-21 08:09:38 UTC) #5 
On 2016/07/21 08:07:11, Matt Giuca wrote:
> sammc: For initial review. Thanks!

Wait, this is the wrong CL.

Powered by Google App Engine
This is Rietveld 408576698