Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1879973005: [compiler] Fix optimized code lookup in GetLazyCode. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Fix optimized code lookup in GetLazyCode. This makes sure that when cached optimized code is found while doing lazy compilation via Compiler::Compile installs any existing literals array as well. R=mvstanton@chromium.org Committed: https://crrev.com/35395d988e94864f17cafb59de9700be114a4f14 Cr-Commit-Position: refs/heads/master@{#35477}

Patch Set 1 #

Patch Set 2 : Add assertion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/compiler.cc View 1 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-13 12:16:53 UTC) #1
mvstanton
lgtm
4 years, 8 months ago (2016-04-13 13:18:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879973005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879973005/20001
4 years, 8 months ago (2016-04-14 09:17:52 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-14 09:20:12 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 09:20:43 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/35395d988e94864f17cafb59de9700be114a4f14
Cr-Commit-Position: refs/heads/master@{#35477}

Powered by Google App Engine
This is Rietveld 408576698