Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: content/public/renderer/content_renderer_client.h

Issue 18799006: Extension Error Piping - Blink: Chrome Side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Include backwards-compatible method for staggered landing with Blink Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/view_messages.h ('k') | content/public/renderer/content_renderer_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/renderer/content_renderer_client.h
diff --git a/content/public/renderer/content_renderer_client.h b/content/public/renderer/content_renderer_client.h
index a00e1a9414bb7898cfdc0da90a747b83166cbea5..f3ecf7d908d219c8b6aacd0cf07b50494532e7ee 100644
--- a/content/public/renderer/content_renderer_client.h
+++ b/content/public/renderer/content_renderer_client.h
@@ -243,6 +243,15 @@ class CONTENT_EXPORT ContentRendererClient {
// Returns true if the page at |url| can use Pepper MediaStream APIs.
virtual bool AllowPepperMediaStreamAPI(const GURL& url);
+
+ // Returns true if we should report a detailed message (including a stack
+ // trace) for console [logs|errors|exceptions]. |source| is the WebKit-
+ // reported source for the error; this can point to a page or a script,
+ // and can be external (e.g., "http://www.google.com"), extension-related
+ // (e.g., "chrome-extension://<extension_id>/background.js"), or internal
jam 2013/08/25 07:12:58 nit: it's a layering violation to mention concepts
Devlin 2013/08/26 20:32:40 Done in https://codereview.chromium.org/23252006/
+ // (e.g., "event_bindings" or "schemaUtils").
+ virtual bool ShouldReportDetailedMessageForSource(
+ const base::string16& source) const;
};
} // namespace content
« no previous file with comments | « content/common/view_messages.h ('k') | content/public/renderer/content_renderer_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698