Extension Error Piping - Blink: Chrome Side

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
@@ skipping 771 matching lines @@
 
   bool is_invoked_by_hosted_app = extension &&
       extension->is_hosted_app() &&
       extension->web_extent().MatchesURL(app_url);
 
   // Allow built-in extensions and extensions under development.
   bool is_extension_unrestricted = extension &&
       (extension->location() == extensions::Manifest::COMPONENT ||
        extensions::Manifest::IsUnpackedLocation(extension->location()));
 
-  bool is_invoked_by_extension = app_url.SchemeIs("chrome-extension");
+  bool is_invoked_by_extension = app_url.SchemeIs(extensions::kExtensionScheme);
 
   // The NaCl PDF viewer is always allowed and can use 'Dev' interfaces.
   bool is_nacl_pdf_viewer =
       (is_extension_from_webstore &&
-       manifest_url.SchemeIs("chrome-extension") &&
+       manifest_url.SchemeIs(extensions::kExtensionScheme) &&
        manifest_url.host() == "acadkphlmlegjaadjagenfimbpphcgnh");
 
   // Allow Chrome Web Store extensions, built-in extensions and extensions
   // under development if the invocation comes from a URL with an extension
   // scheme. Also allow invocations if they are from whitelisted URLs or
   // if --enable-nacl is set.
   bool is_nacl_allowed = is_nacl_unrestricted ||
                          is_whitelisted_url ||
                          is_nacl_pdf_viewer ||
                          is_invoked_by_hosted_app ||
@@ skipping 468 matching lines @@
   }
   // Allow access for tests.
   if (CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnablePepperTesting)) {
     return true;
   }
 #endif  // !defined(OS_ANDROID)
   return false;
 }
 
+bool ChromeContentRendererClient::ShouldReportDetailedMessage(
+    const GURL& url) const {
+  // Currently, we are only interested in anything caused by an extension.
+  // A source may have come from an extension if it is either directly from the
+  // extension's url (chrome-extension://), or if it did not come from a real
+  // url at all (as in the source being "event_bindings"). The latter condition
+  // may catch a few extra cases, but we are only after heuristic accuracy.
+  return !url.is_empty() &&

[pfeldman, 2013/07/17 09:08:38]

This does not look good. It will make all the //@ sourceURL users end up here.
You probably want only valid extension URLs here. Why filtering by URL at all? I
thought that extensions are only running in their own processes / isolates. You
should instead make a decision based on the v8 context.

[Devlin, 2013/07/17 22:13:54]

Commented in other CL (https://codereview.chromium.org/18822004/).

+         (!url.is_valid() || url.SchemeIs(extensions::kExtensionScheme));
+}
 
 }  // namespace chrome