Extension Error Piping - Blink: Chrome Side

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 750 matching lines @@
     item_list.push_back(item);
   }
 
   WebDragData result;
   result.initialize();
   result.setItems(item_list);
   result.setFilesystemId(drop_data.filesystem_id);
   return result;
 }
 
+bool IsSourceFromExtension(const std::string& source) {
+  static const char schema_delimeter[] = "://";

[Yoyo Zhou, 2013/07/10 23:39:10]

kStandardSchemeSeparator

[Devlin, 2013/07/11 00:55:35]

Much less cringe-worthy, but not needed if we go with a GURL. =)

+  static const char extension_url_prefix[] = "chrome-extension://";

[Matt Perry, 2013/07/10 23:43:13]

This is defined in
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/common/...

I think Yoyo's right - referencing extensions in content is a layering
violation. You'll need another layer of indirection to call out to the Chrome
layer. chrome_content_renderer_client.h looks like the right place.

[Devlin, 2013/07/11 00:55:35]

I was wondering about that, but saw other references to extensions lying around,
so wasn't quite sure. Done.

+  return !source.empty() &&
+         (source.find(schema_delimeter) == std::string::npos ||

[Yoyo Zhou, 2013/07/10 23:39:10]

Can you document why these are the cases we care about?

[Devlin, 2013/07/11 00:55:35]

Done.

+          source.find(extension_url_prefix) == 0);
+}
+
 }  // namespace
 
 RenderViewImpl::RenderViewImpl(RenderViewImplParams* params)
     : RenderWidget(WebKit::WebPopupTypeNone,
                    params->screen_info,
                    params->swapped_out),
       webkit_preferences_(params->webkit_prefs),
       send_content_state_immediately_(false),
       enabled_bindings_(0),
       send_preferred_size_changes_(false),
@@ skipping 1479 matching lines @@
       NOTREACHED();
   }
 
   Send(new ViewHostMsg_AddMessageToConsole(routing_id_,
                                            static_cast<int32>(log_severity),
                                            message.text,
                                            static_cast<int32>(source_line),
                                            source_name));
 }
 
+bool RenderViewImpl::shouldReportDetailedMessage(const WebString& source) {

[Matt Perry, 2013/07/10 23:43:13]

Why is source a string and not a URL? It would be easier to check the scheme as
a URL.

[Devlin, 2013/07/11 00:55:35]

Well, it comes from WebKit, and is a String in most places there (plus, their
equivalent, a KURL, isn't public).  I kinda thought that initializing a GURL (a
surprisingly expensive process) might be overkill for the checks we need, but it
does make the code more readable and extendable. Changed it to a GURL once it
gets to our side.

+  return IsSourceFromExtension(source.utf8().data());
+}
+
+void RenderViewImpl::reportDetailedMessage(const WebString& source,
+                                           WebConsoleMessage::Level level,
+                                           const WebString& message,
+                                           const WebString& jsonStackTrace) {
+  LOG(WARNING) << "RenderViewImpl::reportDetailedErrorMessage()"
+      << "\n  Source:  " << base::string16(source)
+      << "\n  Message: " << base::string16(message)
+      << "\n  Stack:   " << base::string16(jsonStackTrace);
+}
+
 void RenderViewImpl::printPage(WebFrame* frame) {
   FOR_EACH_OBSERVER(RenderViewObserver, observers_,
                     PrintPage(frame, handling_input_event_));
 }
 
 WebKit::WebNotificationPresenter* RenderViewImpl::notificationPresenter() {
   return notification_provider_;
 }
 
 bool RenderViewImpl::enumerateChosenDirectory(
@@ skipping 4531 matching lines @@
     WebURL url = icon_urls[i].iconURL();
     if (!url.isEmpty())
       urls.push_back(FaviconURL(url,
                                 ToFaviconType(icon_urls[i].iconType())));
   }
   SendUpdateFaviconURL(urls);
 }
 
 
 }  // namespace content