Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 18799004: Don't insert redundant BR for merging (Closed)

Created:
7 years, 5 months ago by yosin_UTC9
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, ​a.bah_samsung.com
Visibility:
Public.

Description

This patch changes delete selection process not to insert redundant BR element for merging. * editing/deleting/delete-br-001.html: This patch keeps origin BRs. * editing/deleting/delete-before-block-image-2-expected.txt This patch keeps an origin IMG element rather than inserting new one. * editing/deleting/delete-br-001.html This patch keeps original BR elements rather than removing BR then inserting BR again. * editing/deleting/delete-br-after-image.html This patch adds a new test described in issue report. * editing/deleting/delete-inline-br.html Imported from http://trac.webkit.org/changeset/154479 * editing/inserting/font-size-clears-from-typing-style-expected.txt This patch doesn't causes redundant block, DIV, merging. BUG=173835, 235742 R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157505

Patch Set 1 : 2013-07-24T17:05:12 #

Patch Set 2 : 2013-09-05T16:10:37 #

Messages

Total messages: 9 (0 generated)
yosin_UTC9
Hi, Could you review this patch? Thanks in advance.
7 years, 5 months ago (2013-07-10 09:08:58 UTC) #1
ojan
I really don't know this code well enough to know if the change is correct. ...
7 years, 5 months ago (2013-07-11 23:50:06 UTC) #2
yosin_UTC9
ping...
7 years, 5 months ago (2013-07-25 01:28:48 UTC) #3
yosin_UTC9
Levi... It seems this patch covers more cases than https://codereview.chromium.org/23311004/
7 years, 3 months ago (2013-09-05 07:25:33 UTC) #4
eseidel
lgtm I'm willing to bet that Yosin will know this code better than any of ...
7 years, 3 months ago (2013-09-09 20:30:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/18799004/17001
7 years, 3 months ago (2013-09-09 20:30:44 UTC) #6
leviw_travelin_and_unemployed
On 2013/09/09 20:30:33, eseidel wrote: > lgtm > > I'm willing to bet that Yosin ...
7 years, 3 months ago (2013-09-09 20:32:29 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=4778
7 years, 3 months ago (2013-09-09 22:53:22 UTC) #8
yosin_UTC9
7 years, 3 months ago (2013-09-10 05:48:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r157505 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698