Make popups closer to pixel-perfect. The main problem is that the toolbar is...

Make popups closer to pixel-perfect.  The main problem is that the toolbar is constrained to the width of the client area, when it actually needs to extend out two pixesl on each side into the current nonclient area.  I don't have a good fix for this, hoping Ben comes up with a brilliant idea.

BUG=5054
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8726

[Peter Kasting, 2009-01-27 00:48:27]

Ben, the main reason I'm having you review this instead of Scott is so that you
can sanity-check that plumbing functions like "IsToolbarDisplayModeNormal()" is
a sane thing to do.

[Peter Kasting, 2009-01-27 04:30:35]

Incidentally, I spent a bit of time thinking about how to solve the "toolbar is
too narrow" issue, although I'd probably address that in a followup patch.

The best fix I've come up with is to find the code that draws the endcaps on the
location bar, and instead draw those directly in the nonclient area inside the
opaque nonclient view.  The location bar itself can just be the full width of
the browser view, with no endcaps.  Obviously we'd only do this in the
location-bar-only mode; in normal toolbar mode things would be unchanged.  This
is something of a hack in terms of having bits of code scattered all over to
draw what appears to be a single visual element, but it would be the simplest
patch to write.

The best alternative would probably be to hoist the toolbar out of the browser
view, at least in this case, and have it live alongside the browser view in the
hierarchy.  This would probably throw some wrenches at Ben's design.

Comments welcome.

[Ben Goodger (Google), 2009-01-27 17:53:31]

OK, as long as this doesn't make anything worse.