Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 1879863002: Reland of [chromedriver] Listen on IPv6 on IPv6-only hosts (part 2). (Closed)

Created:
4 years, 8 months ago by samuong
Modified:
4 years, 8 months ago
Reviewers:
stgao
CC:
chromium-reviews, cbentzel+watch_chromium.org, samuong+watch_chromium.org, gmanikpure
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [chromedriver] Listen on IPv6 on IPv6-only hosts (part 2). This contains the changes to net_util.*, which now uses "localhost" instead of "127.0.0.1", so that we can connect to IPv6-enabled instances of DevTools. It also contains some extra logging for debugging purposes. BUG=chromedriver:779 TBR=stgao@chromium.org Committed: https://crrev.com/41bb0ad915fa141f6dd54db93de74105eebb20b2 Cr-Commit-Position: refs/heads/master@{#388538}

Patch Set 1 #

Patch Set 2 : add logging #

Patch Set 3 : better logging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M chrome/test/chromedriver/net/net_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/net/net_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/net/websocket.cc View 1 2 3 chunks +15 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/server/chromedriver_server.cc View 1 2 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
samuong
ptal
4 years, 8 months ago (2016-04-18 21:32:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879863002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879863002/40001
4 years, 8 months ago (2016-04-20 17:01:29 UTC) #5
stgao
lgtm
4 years, 8 months ago (2016-04-20 17:42:22 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-20 18:32:48 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:24:58 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/41bb0ad915fa141f6dd54db93de74105eebb20b2
Cr-Commit-Position: refs/heads/master@{#388538}

Powered by Google App Engine
This is Rietveld 408576698