Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1879853002: Annotation for `@optionalTypeArgs` (linter#196). (Closed)

Created:
4 years, 8 months ago by pquitslund
Modified:
4 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M pkg/meta/lib/meta.dart View 2 chunks +10 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
4 years, 8 months ago (2016-04-11 23:32:35 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/1879853002/diff/1/pkg/meta/lib/meta.dart File pkg/meta/lib/meta.dart (right): https://codereview.chromium.org/1879853002/diff/1/pkg/meta/lib/meta.dart#newcode59 pkg/meta/lib/meta.dart:59: /// Used to annotate a class declaration `c`. ...
4 years, 8 months ago (2016-04-11 23:51:24 UTC) #3
pquitslund
Committed patchset #1 (id:1) manually as 1cbf0a4313ff4a0f52259caf1d5e87593317abe8 (presubmit successful).
4 years, 8 months ago (2016-04-11 23:55:53 UTC) #5
pquitslund
4 years, 8 months ago (2016-04-11 23:58:22 UTC) #6
Message was sent while issue was closed.
Thanks!

https://codereview.chromium.org/1879853002/diff/1/pkg/meta/lib/meta.dart
File pkg/meta/lib/meta.dart (right):

https://codereview.chromium.org/1879853002/diff/1/pkg/meta/lib/meta.dart#newc...
pkg/meta/lib/meta.dart:59: /// Used to annotate a class declaration `c`.
Indicates that any type arguments
On 2016/04/11 23:51:24, Brian Wilkerson wrote:
> nit: class names are typically capitalized

Fixed!

Powered by Google App Engine
This is Rietveld 408576698