Android: Browser-side scheduling latency tweaks

content/browser/renderer_host/compositor_impl_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/compositor_impl_android.h"
 
 #include <android/bitmap.h>
 #include <android/native_window_jni.h>
 #include <stdint.h>
 #include <utility>
@@ skipping 142 matching lines @@
   base::CancelableCallback<void(const std::vector<ui::LatencyInfo>&,
                                 gfx::SwapResult)>
       swap_buffers_completion_callback_;
   scoped_ptr<cc::OverlayCandidateValidator> overlay_candidate_validator_;
 };
 
 class ExternalBeginFrameSource : public cc::BeginFrameSourceBase,
                                  public CompositorImpl::VSyncObserver {
  public:
   ExternalBeginFrameSource(CompositorImpl* compositor)
-      : compositor_(compositor) {
+      : compositor_(compositor), needs_begin_frames_(false) {
     compositor_->AddObserver(this);
   }
 
   ~ExternalBeginFrameSource() override {
     compositor_->RemoveObserver(this);
   }
 
   // cc::BeginFrameSourceBase implementation:
   void OnNeedsBeginFramesChanged(bool needs_begin_frames) override {
+    TRACE_EVENT1("compositor", "OnNeedsBeginFramesChanged",
+                 "needs_begin_frames", needs_begin_frames);
     compositor_->OnNeedsBeginFramesChange(needs_begin_frames);
+    needs_begin_frames_ = needs_begin_frames;
+    if (needs_begin_frames) {

[no sievers, 2016/04/11 23:10:10]

Oh I was going to ask:

Should I also remember the last vsync to make sure that we didn't already send a
BeginFrame() this interval, or can this not happen (or rather does not matter)
because the scheduler would have not drawn for a frame if it previously turned
off BeginFrames?

+      base::TimeTicks now = base::TimeTicks::Now();
+      // Since |needs_begin_frames_| turned on, the scheduler wants to draw,
+      // so the dealine doesn't matter much. But pass something large enough
+      // to make sure we don't get discarded in BeginRetroFrame(), see
+      // crbug.com/602485.
+      base::TimeTicks deadline = now + base::TimeDelta::FromMilliseconds(16);
+      cc::BeginFrameArgs args(cc::BeginFrameArgs::Create(
+          BEGINFRAME_FROM_HERE, now, deadline,
+          base::TimeDelta::FromMilliseconds(16), cc::BeginFrameArgs::NORMAL));
+      base::Closure tick =
+          base::Bind(&ExternalBeginFrameSource::CallOnBeginFrame,
+                     base::Unretained(this), args);
+      base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, tick);
+    }
   }
 
   // CompositorImpl::VSyncObserver implementation:
   void OnVSync(base::TimeTicks frame_time,
                base::TimeDelta vsync_period) override {
-    CallOnBeginFrame(cc::BeginFrameArgs::Create(
-        BEGINFRAME_FROM_HERE, frame_time, base::TimeTicks::Now(), vsync_period,
-        cc::BeginFrameArgs::NORMAL));
+    base::TimeTicks deadline = frame_time + 2 * vsync_period / 3;
+    if (needs_begin_frames_) {
+      CallOnBeginFrame(
+          cc::BeginFrameArgs::Create(BEGINFRAME_FROM_HERE, frame_time, deadline,
+                                     vsync_period, cc::BeginFrameArgs::NORMAL));
+    }
   }
 
  private:
   CompositorImpl* compositor_;
+  bool needs_begin_frames_;
 };
 
 static bool g_initialized = false;
 
 base::LazyInstance<cc::SurfaceManager> g_surface_manager =
     LAZY_INSTANCE_INITIALIZER;
 
 int g_surface_id_namespace = 0;
 
 class SingleThreadTaskGraphRunner : public cc::SingleThreadTaskGraphRunner {
@@ skipping 203 matching lines @@
 
 void CompositorImpl::SetHasTransparentBackground(bool flag) {
   has_transparent_background_ = flag;
   if (host_)
     host_->set_has_transparent_background(flag);
 }
 
 void CompositorImpl::SetNeedsComposite() {
   if (!host_->visible())
     return;
+  TRACE_EVENT0("compositor", "Compositor::SetNeedsComposite");
   host_->SetNeedsAnimate();
 }
 
 static scoped_ptr<WebGraphicsContext3DCommandBufferImpl>
 CreateGpuProcessViewContext(
     const scoped_refptr<gpu::GpuChannelHost>& gpu_channel_host,
     const gpu::gles2::ContextCreationAttribHelper& attributes,
     int surface_id) {
   GURL url("chrome://gpu/Compositor::createContext3D");
   static const size_t kBytesPerPixel = 4;
@@ skipping 159 matching lines @@
 void CompositorImpl::AddObserver(VSyncObserver* observer) {
   observer_list_.AddObserver(observer);
 }
 
 void CompositorImpl::RemoveObserver(VSyncObserver* observer) {
   observer_list_.RemoveObserver(observer);
 }
 
 cc::UIResourceId CompositorImpl::CreateUIResource(
     cc::UIResourceClient* client) {
+  TRACE_EVENT0("compositor", "CompositorImpl::CreateUIResource");
   return host_->CreateUIResource(client);
 }
 
 void CompositorImpl::DeleteUIResource(cc::UIResourceId resource_id) {
+  TRACE_EVENT0("compositor", "CompositorImpl::DeleteUIResource");
   host_->DeleteUIResource(resource_id);
 }
 
 bool CompositorImpl::SupportsETC1NonPowerOfTwo() const {
   return gpu_capabilities_.texture_format_etc1_npot;
 }
 
 void CompositorImpl::DidPostSwapBuffers() {
   TRACE_EVENT0("compositor", "CompositorImpl::DidPostSwapBuffers");
   pending_swapbuffers_++;
@@ skipping 40 matching lines @@
   needs_begin_frames_ = needs_begin_frames;
   if (needs_begin_frames_)
     root_window_->RequestVSyncUpdate();
 }
 
 void CompositorImpl::SetNeedsAnimate() {
   needs_animate_ = true;
   if (!host_->visible())
     return;
 
+  TRACE_EVENT0("compositor", "Compositor::SetNeedsAnimate");
   host_->SetNeedsAnimate();
 }
 
 }  // namespace content