Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: tools/gyp/v8.gyp

Issue 1879793002: Fix android_arm build hosted on Mac (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix Windows build break Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/standalone.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index e0fd8ebebe9bed52acf14c519e1e54cc7ac54dd3..3a8427108b1a7bad535d7cca0f311dbcf4130b68 100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -1751,11 +1751,12 @@
],
'link_settings': {
'target_conditions': [
- ['_toolset=="host"', {
+ ['_toolset=="host" and host_os!="mac"', {
# Only include libdl and librt on host builds because they
# are included by default on Android target builds, and we
# don't want to re-include them here since this will change
# library order and break (see crbug.com/469973).
+ # These libraries do not exist on Mac hosted builds.
'libraries': [
'-ldl',
'-lrt'
« no previous file with comments | « build/standalone.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698