Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Issue 1879793002: Fix android_arm build hosted on Mac (Closed)

Created:
4 years, 8 months ago by robtsuk
Modified:
4 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix android_arm build hosted on Mac Fixes for misnamed toolchain from https://github.com/appcelerator/v8_titanium. Added a way to specify the NDK path since the Mac versions of the NDK aren't checked into the tools repo. Disabled a few dependencies which do not build on the Mac but which aren't needed for building usable V8 static libraries. Made the including of libdl and librt omitted for Mac hosted builds. BUG= Committed: https://crrev.com/31355336d1e1ba0d8b8919ccf7338700b9df1900 Cr-Commit-Position: refs/heads/master@{#35456}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix Windows build break #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -11 lines) Patch
M Makefile View 1 chunk +5 lines, -0 lines 0 comments Download
M Makefile.android View 2 chunks +10 lines, -0 lines 0 comments Download
M build/all.gyp View 2 chunks +9 lines, -4 lines 0 comments Download
M build/standalone.gypi View 1 3 chunks +22 lines, -6 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Jakob Kummerow
lgtm
4 years, 8 months ago (2016-04-13 16:29:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879793002/1
4 years, 8 months ago (2016-04-13 16:29:20 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/15953)
4 years, 8 months ago (2016-04-13 16:31:51 UTC) #6
Jakob Kummerow
https://codereview.chromium.org/1879793002/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/1879793002/diff/1/build/standalone.gypi#newcode360 build/standalone.gypi:360: 'host_ld': '<!(which ld)', This "which ld" (along with "which ...
4 years, 8 months ago (2016-04-13 19:50:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879793002/20001
4 years, 8 months ago (2016-04-13 22:53:41 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 23:12:02 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 23:13:47 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/31355336d1e1ba0d8b8919ccf7338700b9df1900
Cr-Commit-Position: refs/heads/master@{#35456}

Powered by Google App Engine
This is Rietveld 408576698