Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1879753002:
clang update.py: When running tests on Windows, make sure DIA works. (Closed)
|
Created:
4 years, 8 months ago by Nico Modified:
4 years, 8 months ago Reviewers:
hans CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionclang update.py: When running tests on Windows, make sure DIA works.
LLVM's DIA reading code either needs DIA registered in the registry,
or it needs msdia140.dll somewhere. Copy msdia140.dll from the hermetic
toolchain into the bin/ directory so it's next to llvm-symbolizer.exe
and friends. (This means the tests that package.py runs will only all
pass for people and bots that have access to the hermetic toolchain.)
Also do this after downloading clang. (Here it's not guaranteed that
people have access to the hermetic toolchain -- the script will fall
back to a MSVC install and copy from there. Since this
requires msdia140.dll, this means we now require either the hermetic
toolchain or an installed MSVS2015. If this caused problems, we can
reconsider.)
BUG=596201
Committed: https://crrev.com/bf3b64ab66179b2435fc7b10cfd091247b8cab87
Cr-Commit-Position: refs/heads/master@{#386745}
Patch Set 1 #Patch Set 2 : copy dia instead #Patch Set 3 : . #
Total comments: 2
Patch Set 4 : comment #Messages
Total messages: 15 (8 generated)
Description was changed from ========== clang update.py: When running tests on Windows, make sure DIA works. BUG=596201 ========== to ========== clang update.py: When running tests on Windows, make sure DIA works. LLVM's DIA reading path either needs DIA registered in the registry, or it needs msdia140.dll somewhere. Copy msdia140.dll from the hermetic toolchain into the bin/ directory so it's next to llvm-symbolizer.exe and friends. (This means the tests that package.py runs will only all pass for people and bots that have access to the hermetic toolchain.) Also do this after downloading clang. (Here it's not guaranteed that people have access to the hermetic toolchain.) BUG=596201 ==========
Description was changed from ========== clang update.py: When running tests on Windows, make sure DIA works. LLVM's DIA reading path either needs DIA registered in the registry, or it needs msdia140.dll somewhere. Copy msdia140.dll from the hermetic toolchain into the bin/ directory so it's next to llvm-symbolizer.exe and friends. (This means the tests that package.py runs will only all pass for people and bots that have access to the hermetic toolchain.) Also do this after downloading clang. (Here it's not guaranteed that people have access to the hermetic toolchain.) BUG=596201 ========== to ========== clang update.py: When running tests on Windows, make sure DIA works. LLVM's DIA reading path either needs DIA registered in the registry, or it needs msdia140.dll somewhere. Copy msdia140.dll from the hermetic toolchain into the bin/ directory so it's next to llvm-symbolizer.exe and friends. (This means the tests that package.py runs will only all pass for people and bots that have access to the hermetic toolchain.) Also do this after downloading clang. (Here it's not guaranteed that people have access to the hermetic toolchain -- the script will fall back to a MSVC install and copy from there. Since this requires msdia140.dll, this means we now require either the hermetic toolchain or an installed MSVS2015. If this caused problems, we can reconsider.) BUG=596201 ==========
thakis@chromium.org changed reviewers: + hans@chromium.org
> LLVM's DIA reading path either needs DIA registered in the registry, > or it needs msdia140.dll somewhere. I got confused by "DIA reading path". I suppose you mean path as in code path? Maybe this could be formulated better. LGTM https://codereview.chromium.org/1879753002/diff/40001/tools/clang/scripts/upd... File tools/clang/scripts/update.py (right): https://codereview.chromium.org/1879753002/diff/40001/tools/clang/scripts/upd... tools/clang/scripts/update.py:224: print "Copying %s to %s" % (src, dst) Hmm, why do we print *after* calling shutil.copy? This is my fault, but maybe you can swap these around while you're here? Otherwise I'll do it.
Description was changed from ========== clang update.py: When running tests on Windows, make sure DIA works. LLVM's DIA reading path either needs DIA registered in the registry, or it needs msdia140.dll somewhere. Copy msdia140.dll from the hermetic toolchain into the bin/ directory so it's next to llvm-symbolizer.exe and friends. (This means the tests that package.py runs will only all pass for people and bots that have access to the hermetic toolchain.) Also do this after downloading clang. (Here it's not guaranteed that people have access to the hermetic toolchain -- the script will fall back to a MSVC install and copy from there. Since this requires msdia140.dll, this means we now require either the hermetic toolchain or an installed MSVS2015. If this caused problems, we can reconsider.) BUG=596201 ========== to ========== clang update.py: When running tests on Windows, make sure DIA works. LLVM's DIA reading code either needs DIA registered in the registry, or it needs msdia140.dll somewhere. Copy msdia140.dll from the hermetic toolchain into the bin/ directory so it's next to llvm-symbolizer.exe and friends. (This means the tests that package.py runs will only all pass for people and bots that have access to the hermetic toolchain.) Also do this after downloading clang. (Here it's not guaranteed that people have access to the hermetic toolchain -- the script will fall back to a MSVC install and copy from there. Since this requires msdia140.dll, this means we now require either the hermetic toolchain or an installed MSVS2015. If this caused problems, we can reconsider.) BUG=596201 ==========
https://codereview.chromium.org/1879753002/diff/40001/tools/clang/scripts/upd... File tools/clang/scripts/update.py (right): https://codereview.chromium.org/1879753002/diff/40001/tools/clang/scripts/upd... tools/clang/scripts/update.py:224: print "Copying %s to %s" % (src, dst) On 2016/04/12 16:47:23, hans wrote: > Hmm, why do we print *after* calling shutil.copy? > > This is my fault, but maybe you can swap these around while you're here? > Otherwise I'll do it. Done.
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hans@chromium.org Link to the patchset: https://codereview.chromium.org/1879753002/#ps60001 (title: "comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879753002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879753002/60001
Message was sent while issue was closed.
Description was changed from ========== clang update.py: When running tests on Windows, make sure DIA works. LLVM's DIA reading code either needs DIA registered in the registry, or it needs msdia140.dll somewhere. Copy msdia140.dll from the hermetic toolchain into the bin/ directory so it's next to llvm-symbolizer.exe and friends. (This means the tests that package.py runs will only all pass for people and bots that have access to the hermetic toolchain.) Also do this after downloading clang. (Here it's not guaranteed that people have access to the hermetic toolchain -- the script will fall back to a MSVC install and copy from there. Since this requires msdia140.dll, this means we now require either the hermetic toolchain or an installed MSVS2015. If this caused problems, we can reconsider.) BUG=596201 ========== to ========== clang update.py: When running tests on Windows, make sure DIA works. LLVM's DIA reading code either needs DIA registered in the registry, or it needs msdia140.dll somewhere. Copy msdia140.dll from the hermetic toolchain into the bin/ directory so it's next to llvm-symbolizer.exe and friends. (This means the tests that package.py runs will only all pass for people and bots that have access to the hermetic toolchain.) Also do this after downloading clang. (Here it's not guaranteed that people have access to the hermetic toolchain -- the script will fall back to a MSVC install and copy from there. Since this requires msdia140.dll, this means we now require either the hermetic toolchain or an installed MSVS2015. If this caused problems, we can reconsider.) BUG=596201 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== clang update.py: When running tests on Windows, make sure DIA works. LLVM's DIA reading code either needs DIA registered in the registry, or it needs msdia140.dll somewhere. Copy msdia140.dll from the hermetic toolchain into the bin/ directory so it's next to llvm-symbolizer.exe and friends. (This means the tests that package.py runs will only all pass for people and bots that have access to the hermetic toolchain.) Also do this after downloading clang. (Here it's not guaranteed that people have access to the hermetic toolchain -- the script will fall back to a MSVC install and copy from there. Since this requires msdia140.dll, this means we now require either the hermetic toolchain or an installed MSVS2015. If this caused problems, we can reconsider.) BUG=596201 ========== to ========== clang update.py: When running tests on Windows, make sure DIA works. LLVM's DIA reading code either needs DIA registered in the registry, or it needs msdia140.dll somewhere. Copy msdia140.dll from the hermetic toolchain into the bin/ directory so it's next to llvm-symbolizer.exe and friends. (This means the tests that package.py runs will only all pass for people and bots that have access to the hermetic toolchain.) Also do this after downloading clang. (Here it's not guaranteed that people have access to the hermetic toolchain -- the script will fall back to a MSVC install and copy from there. Since this requires msdia140.dll, this means we now require either the hermetic toolchain or an installed MSVS2015. If this caused problems, we can reconsider.) BUG=596201 Committed: https://crrev.com/bf3b64ab66179b2435fc7b10cfd091247b8cab87 Cr-Commit-Position: refs/heads/master@{#386745} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/bf3b64ab66179b2435fc7b10cfd091247b8cab87 Cr-Commit-Position: refs/heads/master@{#386745}
Message was sent while issue was closed.
On 2016/04/12 18:27:26, commit-bot: I haz the power wrote: > Patchset 4 (id:??) landed as > https://crrev.com/bf3b64ab66179b2435fc7b10cfd091247b8cab87 > Cr-Commit-Position: refs/heads/master@{#386745} It is breaking PDFium now which doesn't have hermetic toolchain, nor requires VS2015. |
