Expose cellular signal strength on Android to native

net/android/cellular_signal_strength_unittest.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/android/cellular_signal_strength.h"
+
+#include <stdint.h>
+
+#include "net/base/network_change_notifier.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace net {
+
+namespace {
+
+TEST(CellularSignalStrengthAndroidTest, RssiTest) {
+  // This test should be run only when the device has an active cellular
+  // connection.
+  if (!NetworkChangeNotifier::IsConnectionCellular(
+          NetworkChangeNotifier::GetConnectionType())) {
+    return;

[pauljensen, 2016/06/10 13:52:15]

if the device isn't using cellular, can we at least call your api to make sure
it doesn't crash?

[tbansal1, 2016/06/16 00:58:05]

Done.

+  }
+  int rssi = INT32_MIN;

[bengr, 2016/06/10 20:57:37]

Shouldn't this be set to CellularSignalStrengthError.ERROR_NOT_SUPPORTED?

[tbansal1, 2016/06/16 00:58:08]

Done.

+  EXPECT_TRUE(android::cellular_signal_strength::GetRssiDbm(&rssi));
+  // RSSI (in dbM) should typically be between -100 and 0.
+  EXPECT_LE(-100, rssi);
+  EXPECT_GE(0, rssi);

[bengr, 2016/06/10 20:57:37]

If you change rssi to signalStrengthDbm elsewhere, you should do it here to, and
everywhere.

[tbansal1, 2016/06/16 00:58:06]

Done.

+}
+
+TEST(CellularSignalStrengthAndroidTest, SignalLevelTest) {
+  // This test should be run only when the device has an active cellular
+  // connection.
+  if (!NetworkChangeNotifier::IsConnectionCellular(
+          NetworkChangeNotifier::GetConnectionType())) {
+    return;

[pauljensen, 2016/06/10 13:52:15]

ditto

[tbansal1, 2016/06/16 00:58:04]

Done.

+  }
+
+  int signal_level = INT32_MIN;
+  EXPECT_TRUE(android::cellular_signal_strength::GetSignalLevel(&signal_level));
+  EXPECT_LE(0, signal_level);
+  EXPECT_GE(4, signal_level);
+}
+
+}  // namespace
+
+}  // namespace net