Quote flags in GN.

Quote flags in GN.

Previously cflags/ldflags/etc. were not automatically quoted by GN. The
original intention was to support having multiple flags in one string which we
don in GYP in some cases (e.g. "-foo -bar"). But this ends up not being
necessary and we never do it.

Furthermore, GN still escapes quote characters in these flags, making it
impossible to manually quote them. The result is the old policy actively
prevents using spaces or quotes in flags. This change automatically quotes
flags like defines and file names already were.

Committed: https://crrev.com/d923cf82900e3c26ab4f989cff62bf2bd6c2810f
Cr-Commit-Position: refs/heads/master@{#386490}

[brettw, 2016-04-11 21:04:05]

brettw@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brettw, 2016-04-11 21:04:09]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-11 21:05:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879723002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879723002/1

[commit-bot: I haz the power, 2016-04-11 21:48:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-11 21:48:10]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2016-04-11 21:58:46]

That fixes the problem I was having with /MANIFESTUAC. Thanks.

lgtm.

[brucedawson, 2016-04-11 21:59:00]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-04-11 21:59:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879723002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879723002/1

[commit-bot: I haz the power, 2016-04-11 22:07:52]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-11 22:09:30]

Description was changed from

==========
Quote flags in GN.

Previously cflags/ldflags/etc. were not automatically quoted by GN. The
original intention was to support having multiple flags in one string which we
don in GYP in some cases (e.g. "-foo -bar"). But this ends up not being
necessary and we never do it.

Furthermore, GN still escapes quote characters in these flags, making it
impossible to manually quote them. The result is the old policy actively
prevents using spaces or quotes in flags. This change automatically quotes
flags like defines and file names already were.
==========

to

==========
Quote flags in GN.

Previously cflags/ldflags/etc. were not automatically quoted by GN. The
original intention was to support having multiple flags in one string which we
don in GYP in some cases (e.g. "-foo -bar"). But this ends up not being
necessary and we never do it.

Furthermore, GN still escapes quote characters in these flags, making it
impossible to manually quote them. The result is the old policy actively
prevents using spaces or quotes in flags. This change automatically quotes
flags like defines and file names already were.

Committed: https://crrev.com/d923cf82900e3c26ab4f989cff62bf2bd6c2810f
Cr-Commit-Position: refs/heads/master@{#386490}
==========

[commit-bot: I haz the power, 2016-04-11 22:09:31]

Patchset 1 (id:??) landed as
https://crrev.com/d923cf82900e3c26ab4f989cff62bf2bd6c2810f
Cr-Commit-Position: refs/heads/master@{#386490}