core/fpdfdoc/cpvt_generateap.cpp - Issue 1879683002: Remove CPDF_Object::GetConstString and overrides

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/cpvt_generateap.cpp

Issue 1879683002: Remove CPDF_Object::GetConstString and overrides (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfdoc/cpvt_generateap.cpp

diff --git a/core/fpdfdoc/cpvt_generateap.cpp b/core/fpdfdoc/cpvt_generateap.cpp

index a837c35801d14bbe606e44739f0304d80b9d5b2b..7b4ad2ff4f6260378ad9fecaed2c9eba04103a68 100644

--- a/core/fpdfdoc/cpvt_generateap.cpp

+++ b/core/fpdfdoc/cpvt_generateap.cpp

@@ -451,7 +451,7 @@ FX_BOOL GenerateWidgetAP(CPDF_Document* pDoc,

} // namespace

FX_BOOL FPDF_GenerateAP(CPDF_Document* pDoc, CPDF_Dictionary* pAnnotDict) {

- if (!pAnnotDict || pAnnotDict->GetConstStringBy("Subtype") != "Widget") {

+ if (!pAnnotDict || pAnnotDict->GetStringBy("Subtype") != "Widget") {

return FALSE;

}

CFX_ByteString field_type = FPDF_GetFieldAttr(pAnnotDict, "FT")->GetString();