core/fpdfapi/fpdf_page/fpdf_page_doc.cpp - Issue 1879683002: Remove CPDF_Object::GetConstString and overrides

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_page/fpdf_page_doc.cpp

Issue 1879683002: Remove CPDF_Object::GetConstString and overrides (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_page/fpdf_page_doc.cpp

diff --git a/core/fpdfapi/fpdf_page/fpdf_page_doc.cpp b/core/fpdfapi/fpdf_page/fpdf_page_doc.cpp

index 2dfccb26d7cecd625a45c5391d472f512dbba922..6cd66185c6f9c5ecb0e8ceb95b57321fb446db80 100644

--- a/core/fpdfapi/fpdf_page/fpdf_page_doc.cpp

+++ b/core/fpdfapi/fpdf_page/fpdf_page_doc.cpp

@@ -326,7 +326,7 @@ CPDF_ColorSpace* CPDF_DocPageData::GetColorSpace(

return nullptr;

if (pCSObj->IsName()) {

- CFX_ByteString name = pCSObj->GetConstString();

+ CFX_ByteString name = pCSObj->GetString();

Tom Sepez 2016/04/11 20:19:46 note: avoids a duplicate alloc here.

CPDF_ColorSpace* pCS = CPDF_ColorSpace::ColorspaceFromName(name);

if (!pCS && pResources) {

CPDF_Dictionary* pList = pResources->GetDictBy("ColorSpace");