mash: Fix ash_sysui crash on startup due to missing AppListShower

mash: Fix ash_sysui crash on startup due to missing AppListShower

ShellDelegateMus needs to provide a stub implementation.

BUG=none
TEST=ash_sysui starts under mash without crashing
TBR=mfomitchev@chromium.org

Committed: https://crrev.com/a6adaac598e4241c09892fa4e2e95ddd70c5a0b0
Cr-Commit-Position: refs/heads/master@{#386431}

[msw, 2016-04-11 17:07:42]

msw@chromium.org changed reviewers:
+ msw@chromium.org

[msw, 2016-04-11 17:07:43]

lgtm with nits

https://codereview.chromium.org/1879603002/diff/1/ash/mus/shell_delegate_mus.cc
File ash/mus/shell_delegate_mus.cc (right):

https://codereview.chromium.org/1879603002/diff/1/ash/mus/shell_delegate_mus....
ash/mus/shell_delegate_mus.cc:97: class AppListShowerStub : public
app_list::AppListShower {
nit: AppListShowerMus? It's readily discernable that these are stubs.

https://codereview.chromium.org/1879603002/diff/1/ash/mus/shell_delegate_mus....
ash/mus/shell_delegate_mus.cc:191: // Individual methods are marked
NOTIMPLEMENTED.
nit: eh, comment not worthwhile?

[James Cook, 2016-04-11 17:13:39]

https://codereview.chromium.org/1879603002/diff/1/ash/mus/shell_delegate_mus.cc
File ash/mus/shell_delegate_mus.cc (right):

https://codereview.chromium.org/1879603002/diff/1/ash/mus/shell_delegate_mus....
ash/mus/shell_delegate_mus.cc:97: class AppListShowerStub : public
app_list::AppListShower {
On 2016/04/11 17:07:43, msw wrote:
> nit: AppListShowerMus? It's readily discernable that these are stubs.

Done.

https://codereview.chromium.org/1879603002/diff/1/ash/mus/shell_delegate_mus....
ash/mus/shell_delegate_mus.cc:191: // Individual methods are marked
NOTIMPLEMENTED.
On 2016/04/11 17:07:43, msw wrote:
> nit: eh, comment not worthwhile?

Done.

[James Cook, 2016-04-11 17:17:10]

Description was changed from

==========
mash: Fix ash_sysui crash on startup due to missing AppListShower

ShellDelegateMus needs to provide a stub implementation.

BUG=none
TEST=ash_sysui starts under mash without crashing
==========

to

==========
mash: Fix ash_sysui crash on startup due to missing AppListShower

ShellDelegateMus needs to provide a stub implementation.

BUG=none
TEST=ash_sysui starts under mash without crashing
TBR=mfomitchev@chromium.org
==========

[James Cook, 2016-04-11 17:17:17]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-04-11 17:17:18]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/1879603002/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2016-04-11 17:17:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879603002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879603002/20001

[commit-bot: I haz the power, 2016-04-11 17:22:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-11 17:22:24]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[James Cook, 2016-04-11 17:40:08]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-04-11 17:40:09]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/1879603002/#ps40001
(title: "fix deps")

[commit-bot: I haz the power, 2016-04-11 17:40:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879603002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879603002/40001

[commit-bot: I haz the power, 2016-04-11 18:54:30]

Description was changed from

==========
mash: Fix ash_sysui crash on startup due to missing AppListShower

ShellDelegateMus needs to provide a stub implementation.

BUG=none
TEST=ash_sysui starts under mash without crashing
TBR=mfomitchev@chromium.org
==========

to

==========
mash: Fix ash_sysui crash on startup due to missing AppListShower

ShellDelegateMus needs to provide a stub implementation.

BUG=none
TEST=ash_sysui starts under mash without crashing
TBR=mfomitchev@chromium.org
==========

[commit-bot: I haz the power, 2016-04-11 18:54:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-11 18:56:03]

Description was changed from

==========
mash: Fix ash_sysui crash on startup due to missing AppListShower

ShellDelegateMus needs to provide a stub implementation.

BUG=none
TEST=ash_sysui starts under mash without crashing
TBR=mfomitchev@chromium.org
==========

to

==========
mash: Fix ash_sysui crash on startup due to missing AppListShower

ShellDelegateMus needs to provide a stub implementation.

BUG=none
TEST=ash_sysui starts under mash without crashing
TBR=mfomitchev@chromium.org

Committed: https://crrev.com/a6adaac598e4241c09892fa4e2e95ddd70c5a0b0
Cr-Commit-Position: refs/heads/master@{#386431}
==========

[commit-bot: I haz the power, 2016-04-11 18:56:04]

Patchset 3 (id:??) landed as
https://crrev.com/a6adaac598e4241c09892fa4e2e95ddd70c5a0b0
Cr-Commit-Position: refs/heads/master@{#386431}