Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: net/spdy/spdy_session.cc

Issue 18796003: When an idle socket is added back to a socket pool, check for stalled jobs in lower pools (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Undo somewhat tangential change Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_session.cc
===================================================================
--- net/spdy/spdy_session.cc (revision 211652)
+++ net/spdy/spdy_session.cc (working copy)
@@ -504,7 +504,7 @@
if (error == ERR_IO_PENDING)
error = OK;
if (error == OK) {
- connection_->AddLayeredPool(this);
+ connection_->AddHigherLayeredPool(this);
SendInitialSettings();
// Write out any data that we might have to send, such as the
// settings frame.
@@ -998,6 +998,11 @@
active_streams_.erase(it);
DeleteStream(owned_stream.Pass(), status);
+
+ // If there are no active streams, and the socket pool is stalled, try to free
+ // up a socket slot.
+ if (active_streams_.empty() && connection_->IsPoolStalled())
+ RemoveFromPool();
Ryan Hamilton 2013/07/21 14:53:54 akalin has been refactoring SpdySession quite a bi
mmenke 2013/07/22 20:13:33 Yea, this completely doesn't work now. Removing f
}
void SpdySession::CloseCreatedStreamIterator(CreatedStreamSet::iterator it,

Powered by Google App Engine
This is Rietveld 408576698