Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issue 1879543002: [runtime] fix Frame Type compute for wasm code (Closed)

Created:
4 years, 8 months ago by Weiliang
Modified:
4 years, 8 months ago
Reviewers:
titzer, danno
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] fix Frame Type compute for wasm code WASM codes always have a StackFrame::Type marker. BUG= Committed: https://crrev.com/4ea47aa095bb84335c3cf5a5c8e1724c6115ff21 Cr-Commit-Position: refs/heads/master@{#35553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/frames.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Weiliang
PTAL, this fixes "--prof" for WASM code
4 years, 8 months ago (2016-04-11 14:15:49 UTC) #3
titzer
lgtm
4 years, 8 months ago (2016-04-17 15:36:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879543002/1
4 years, 8 months ago (2016-04-17 15:58:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-17 16:30:42 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-17 16:32:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ea47aa095bb84335c3cf5a5c8e1724c6115ff21
Cr-Commit-Position: refs/heads/master@{#35553}

Powered by Google App Engine
This is Rietveld 408576698