Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3208)

Unified Diff: build/config/mac/rules.gni

Issue 1879493002: [iOS/GN] Convert //ios/third_party/ochamcrest to build a framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-framework-bundle
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/mac/rules.gni
diff --git a/build/config/mac/rules.gni b/build/config/mac/rules.gni
index f3f43a1d0df69cd10d6f30bf5e7588a0ea8fe30c..39cbd1386aa7fdfa7265e8e9026b1df86bec6774 100644
--- a/build/config/mac/rules.gni
+++ b/build/config/mac/rules.gni
@@ -45,9 +45,16 @@ template("framework_bundle") {
"*",
[
"assert_no_deps",
+ "configs",
"data_deps",
"output_name",
])
+ if (defined(invoker.configs)) {
Dirk Pranke 2016/04/11 16:38:03 nit: can you add a comment here referencing the bu
Robert Sesek 2016/04/11 18:32:29 Also document this up top as an argument?
sdefresne 2016/04/12 13:05:19 Removed the need for the workaround by using set_d
+ configs += invoker.configs
+ }
+ if (defined(invoker.removed_configs)) {
+ configs -= invoker.removed_configs
+ }
}
bundle_data(_shared_library_bundle_data) {

Powered by Google App Engine
This is Rietveld 408576698