Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1879483002: Revert of Segment strings on dot and comma in addition to space and tab (Closed)

Created:
4 years, 8 months ago by kjellander_chromium
Modified:
4 years, 8 months ago
Reviewers:
behdad, eae, PhistucK, lushnikov
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, Roger Tawa OOO till Jul 10th, Not at Google. Contact bengr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Segment strings on dot and comma in addition to space and tab (patchset #6 id:100001 of https://codereview.chromium.org/1857083002/ ) Reason for revert: Several webkit_tests tests started failing on Mac with this. See http://crbug.com/602207 for details. Original issue's description: > Segment strings on dot and comma in addition to space and tab > > Add dot and comma do the list of word separators in an effort to prevent > hitting the long-word performance cliff when shaping JSON and JS source. > > This is a speculative change based on reported observations as we've yet > been able to reproduce this problem. We do know that performance suffers > somewhat for very long words though, eminently for fonts with ligatures. > > R=lushnikov@chromium.org > BUG=593679 > > Committed: https://crrev.com/63f4a420e42667f2167b7fcf4a9ac8e10f66e792 > Cr-Commit-Position: refs/heads/master@{#386022} TBR=behdad@chromium.org,lushnikov@chromium.org,phistuck@gmail.com,eae@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=593679, 602207

Patch Set 1 #

Patch Set 2 : Rebased and restored virtual/scalefactor{150,200}/fast/hidpi/static/ entries #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -25 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 8 chunks +66 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp View 1 2 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
kjellander_chromium
Created Revert of Segment strings on dot and comma in addition to space and tab
4 years, 8 months ago (2016-04-11 09:46:17 UTC) #1
kjellander_chromium
4 years, 8 months ago (2016-04-11 09:46:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879483002/1
4 years, 8 months ago (2016-04-11 09:46:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/16895) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-11 09:48:51 UTC) #7
kjellander_chromium
I can't say that I fully understand the TestExpectations file, so please pay attention to ...
4 years, 8 months ago (2016-04-11 12:56:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879483002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879483002/100001
4 years, 8 months ago (2016-04-11 12:57:01 UTC) #10
kjellander_chromium
+cc rogerta, kundaji (sheriffs taking over) eae: There seems to be more work needed. Can ...
4 years, 8 months ago (2016-04-11 14:18:26 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 15:05:34 UTC) #13
Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698