Remove requestedStyle from SkTypefaceCache.

Remove requestedStyle from SkTypefaceCache.

The typeface cache contains typefaces which can be compared against to
determine if an already known typeface will work instead of creating a
new typeface id. This is primarily for sharing scaler contexts. How that
typeface was requested is not relevant to this comparison, so don't cache
it. Request caching must be handled separately.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1879423002

Committed: https://skia.googlesource.com/skia/+/82a455f0e9a7a50a399a58be906b48c24aeec056

[bungeman-skia, 2016-04-13 15:14:23]

Description was changed from

==========
Remove requestedStyle from SkTypefaceCache.

The typeface cache contains typefaces which can be compared against to
determine if an already known typeface will work instead of creating a
new typeface id. This is primarily for sharing scaler contexts. How that
typeface was requested is not relevent to this comparison, so don't cache
it. Request caching must be handled separately.
==========

to

==========
Remove requestedStyle from SkTypefaceCache.

The typeface cache contains typefaces which can be compared against to
determine if an already known typeface will work instead of creating a
new typeface id. This is primarily for sharing scaler contexts. How that
typeface was requested is not relevent to this comparison, so don't cache
it. Request caching must be handled separately.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-04-13 15:14:51]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 15:14:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879423002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879423002/1

[commit-bot: I haz the power, 2016-04-13 15:16:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 15:16:29]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[bungeman-skia, 2016-04-13 15:27:37]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 15:27:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879423002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879423002/20001

[bungeman-skia, 2016-04-13 15:33:34]

The CQ bit was unchecked by bungeman@google.com

[bungeman-skia, 2016-04-13 16:57:04]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 16:57:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879423002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879423002/40001

[bungeman-skia, 2016-04-13 17:01:02]

Description was changed from

==========
Remove requestedStyle from SkTypefaceCache.

The typeface cache contains typefaces which can be compared against to
determine if an already known typeface will work instead of creating a
new typeface id. This is primarily for sharing scaler contexts. How that
typeface was requested is not relevent to this comparison, so don't cache
it. Request caching must be handled separately.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove requestedStyle from SkTypefaceCache.

The typeface cache contains typefaces which can be compared against to
determine if an already known typeface will work instead of creating a
new typeface id. This is primarily for sharing scaler contexts. How that
typeface was requested is not relevent to this comparison, so don't cache
it. Request caching must be handled separately.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-04-13 17:01:20]

Description was changed from

==========
Remove requestedStyle from SkTypefaceCache.

The typeface cache contains typefaces which can be compared against to
determine if an already known typeface will work instead of creating a
new typeface id. This is primarily for sharing scaler contexts. How that
typeface was requested is not relevent to this comparison, so don't cache
it. Request caching must be handled separately.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove requestedStyle from SkTypefaceCache.

The typeface cache contains typefaces which can be compared against to
determine if an already known typeface will work instead of creating a
new typeface id. This is primarily for sharing scaler contexts. How that
typeface was requested is not relevant to this comparison, so don't cache
it. Request caching must be handled separately.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-04-13 17:04:01]

bungeman@google.com changed reviewers:
+ mtklein@google.com

[commit-bot: I haz the power, 2016-04-13 17:06:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 17:06:16]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-04-13 19:14:34]

how are we testing this?

[bungeman-skia, 2016-04-13 20:30:25]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 20:30:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879423002/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879423002/50001

[bungeman-skia, 2016-04-13 20:35:02]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 20:35:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879423002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879423002/70001

[commit-bot: I haz the power, 2016-04-13 20:45:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 20:45:19]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-04-13 20:49:06]

It isn't the most inspiring test ever, but it does hit up most of the code
(there is rather less of it now at least). I'd also like to get rid of the
globals soon, since they're currently bugs waiting to happen.

[bungeman-skia, 2016-04-14 14:51:21]

bungeman@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-04-14 15:01:20]

lgtm

[bungeman-skia, 2016-04-14 15:03:41]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2016-04-14 15:03:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879423002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879423002/70001

[commit-bot: I haz the power, 2016-04-14 15:04:50]

Description was changed from

==========
Remove requestedStyle from SkTypefaceCache.

The typeface cache contains typefaces which can be compared against to
determine if an already known typeface will work instead of creating a
new typeface id. This is primarily for sharing scaler contexts. How that
typeface was requested is not relevant to this comparison, so don't cache
it. Request caching must be handled separately.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Remove requestedStyle from SkTypefaceCache.

The typeface cache contains typefaces which can be compared against to
determine if an already known typeface will work instead of creating a
new typeface id. This is primarily for sharing scaler contexts. How that
typeface was requested is not relevant to this comparison, so don't cache
it. Request caching must be handled separately.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/82a455f0e9a7a50a399a58be906b48c24aeec056
==========

[commit-bot: I haz the power, 2016-04-14 15:04:51]

Committed patchset #5 (id:70001) as
https://skia.googlesource.com/skia/+/82a455f0e9a7a50a399a58be906b48c24aeec056