Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1879403002: Fix link error in GYP builds (Closed)

Created:
4 years, 8 months ago by Ben Goodger (Google)
Modified:
4 years, 8 months ago
Reviewers:
Nico, jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix link error in GYP builds TBR=jam@chromium.org BUG= NOTRY=true Committed: https://crrev.com/5222be3c87f9764eb94bb298572554dfbf41daaf Cr-Commit-Position: refs/heads/master@{#387017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M services/shell/shell.gyp View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Ben Goodger (Google)
4 years, 8 months ago (2016-04-13 14:36:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879403002/1
4 years, 8 months ago (2016-04-13 14:36:45 UTC) #3
Nico
lgtm I didn't understand why this helps: It's because https://code.google.com/p/chromium/codesearch#chromium/src/mojo/mojom_bindings_generator_explicit.gypi&l=130 puts sources into the dependency ...
4 years, 8 months ago (2016-04-13 15:11:15 UTC) #5
jam
rs lgtm
4 years, 8 months ago (2016-04-13 16:02:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/53067)
4 years, 8 months ago (2016-04-13 17:18:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879403002/1
4 years, 8 months ago (2016-04-13 17:18:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 17:25:06 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 17:26:36 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5222be3c87f9764eb94bb298572554dfbf41daaf
Cr-Commit-Position: refs/heads/master@{#387017}

Powered by Google App Engine
This is Rietveld 408576698