Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1879393002: git cl: update Gerrit todos and small nits. (Closed)

Created:
4 years, 8 months ago by tandrii(chromium)
Modified:
4 years, 8 months ago
Reviewers:
Bons
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

git cl: update Gerrit todos and small nits. R=andybons@chromium.org BUG=579160 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299894

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -20 lines) Patch
M git_cl.py View 6 chunks +22 lines, -20 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
tandrii(chromium)
4 years, 8 months ago (2016-04-13 14:09:28 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879393002/1
4 years, 8 months ago (2016-04-13 14:09:30 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 14:12:01 UTC) #5
Bons
lgtm
4 years, 8 months ago (2016-04-13 14:18:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879393002/1
4 years, 8 months ago (2016-04-13 14:44:26 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 14:47:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299894

Powered by Google App Engine
This is Rietveld 408576698