Move Node::retarget() to TreeScope::retarget()

Move Node::retarget() to TreeScope::retarget()

It would be better to make TreeScope have this function.
This CL also changes the parameter type from Node to Element because
Element is only the use case, as of now.

BUG=531990
Committed: https://crrev.com/c6bc3bb152e2dd11c60140a702f6ef72ccce4152
Cr-Commit-Position: refs/heads/master@{#387562}

[hayato, 2016-04-13 10:25:00]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 10:25:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879373002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879373002/1

[hayato, 2016-04-13 10:37:15]

Description was changed from

==========
Move Node::retarget() to TreeScope::retarget()

Move Node::retarget() to TreeScope::retarget().
Also changing parameter type from Node to Element because
that's only the use case as of now.

BUG=531990
==========

to

==========
Move Node::retarget() to TreeScope::retarget()

It would be better to make TreeScope have this function.
This CL also changes the parameter type from Node to Element because
Element is only the ouse case, as of now.

BUG=531990
==========

[hayato, 2016-04-13 10:37:56]

hayato@chromium.org changed reviewers:
+ kochi@chromium.org, tkent@chromium.org

[hayato, 2016-04-13 10:37:57]

PTAL

[hayato, 2016-04-13 11:19:16]

Description was changed from

==========
Move Node::retarget() to TreeScope::retarget()

It would be better to make TreeScope have this function.
This CL also changes the parameter type from Node to Element because
Element is only the ouse case, as of now.

BUG=531990
==========

to

==========
Move Node::retarget() to TreeScope::retarget()

It would be better to make TreeScope have this function.
This CL also changes the parameter type from Node to Element because
Element is only the use case, as of now.

BUG=531990
==========

[commit-bot: I haz the power, 2016-04-13 11:56:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 11:56:48]

Dry run: This issue passed the CQ dry run.

[kochi, 2016-04-15 05:40:46]

https://codereview.chromium.org/1879373002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/TreeScope.cpp (right):

https://codereview.chromium.org/1879373002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/TreeScope.cpp:443: return (this ==
&retargeted->treeScope()) ? retargeted : nullptr;
Is there any chance that the result of retarget() is in a different tree scope?
If not the body for outer if is just "return retargeted(*element);".

[hayato, 2016-04-15 07:30:52]

https://codereview.chromium.org/1879373002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/TreeScope.cpp (right):

https://codereview.chromium.org/1879373002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/TreeScope.cpp:443: return (this ==
&retargeted->treeScope()) ? retargeted : nullptr;
Let me leave this as is.

I am aware that the current Node::retarget does not match the spec, though the
current behavior is enough for adjustedFocusedElement.

I will update the TreeScope::retarget() in another patch with a layout test, to
make it match the spec.

[kochi, 2016-04-15 07:35:11]

On 2016/04/15 07:30:52, hayato wrote:
>
https://codereview.chromium.org/1879373002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/dom/TreeScope.cpp (right):
> 
>
https://codereview.chromium.org/1879373002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/dom/TreeScope.cpp:443: return (this ==
> &retargeted->treeScope()) ? retargeted : nullptr;
> Let me leave this as is.
> 
> I am aware that the current Node::retarget does not match the spec, though the
> current behavior is enough for adjustedFocusedElement.
> 
> I will update the TreeScope::retarget() in another patch with a layout test,
to
> make it match the spec.

Okay, lgtm.

[hayato, 2016-04-15 07:40:01]

The CQ bit was checked by hayato@chromium.org

[commit-bot: I haz the power, 2016-04-15 07:40:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1879373002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1879373002/1

[commit-bot: I haz the power, 2016-04-15 09:08:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-15 09:10:04]

Description was changed from

==========
Move Node::retarget() to TreeScope::retarget()

It would be better to make TreeScope have this function.
This CL also changes the parameter type from Node to Element because
Element is only the use case, as of now.

BUG=531990
==========

to

==========
Move Node::retarget() to TreeScope::retarget()

It would be better to make TreeScope have this function.
This CL also changes the parameter type from Node to Element because
Element is only the use case, as of now.

BUG=531990

Committed: https://crrev.com/c6bc3bb152e2dd11c60140a702f6ef72ccce4152
Cr-Commit-Position: refs/heads/master@{#387562}
==========

[commit-bot: I haz the power, 2016-04-15 09:10:06]

Patchset 1 (id:??) landed as
https://crrev.com/c6bc3bb152e2dd11c60140a702f6ef72ccce4152
Cr-Commit-Position: refs/heads/master@{#387562}