third_party/WebKit/LayoutTests/media/track/track-cue-negative-timestamp.html - Issue 1879353002: Convert track tests from video-test.js to testharness.js based

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-cue-negative-timestamp.html

Issue 1879353002: Convert track tests from video-test.js to testharness.js based (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text-expected.txt ('k') | third_party/WebKit/LayoutTests/media/track/track-cue-negative-timestamp-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/track/track-cue-negative-timestamp.html

diff --git a/third_party/WebKit/LayoutTests/media/track/track-cue-negative-timestamp.html b/third_party/WebKit/LayoutTests/media/track/track-cue-negative-timestamp.html

index 83d78779522fb1602b774a6b53f91d5e29b80685..05fa383ca5b74077a1794f9c6464bbe811909d29 100644

--- a/third_party/WebKit/LayoutTests/media/track/track-cue-negative-timestamp.html

+++ b/third_party/WebKit/LayoutTests/media/track/track-cue-negative-timestamp.html

@@ -1,45 +1,34 @@

<!DOCTYPE html>

-<html>

- <head>

- <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

+<title>Tests negative timestamps.</title>

+<script src="../../resources/testharness.js"></script>

+<script src="../../resources/testharnessreport.js"></script>

+<video>

+ <track id="testTrack" src="captions-webvtt/tc013-settings.vtt" default>

+</video>

+<script>

+async_test(function(t) {

+ var track = document.querySelector("track");

- <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

- (Please avoid writing new tests using video-test.js) -->

- <script src=../video-test.js></script>

- <script>

+ track.onload = t.step_func_done(function() {

+ // Test that cues with negative startTime are not added.

+ assert_equals(testTrack.track.cues.length, 4);

+ textCue = new VTTCue(-3439332606, 3.4, "Sausage?");

+ testTrack.track.addCue(textCue);

+ assert_equals(testTrack.track.cues.length, 4);

- function trackLoaded()

- {

- consoleWrite("Test that cues with negative startTime are not added:");

- testExpected("testTrack.track.cues.length", 4);

- run("textCue = new VTTCue(-3439332606, 3.4, 'Sausage?')");

- run("testTrack.track.addCue(textCue)");

- testExpected("testTrack.track.cues.length", 4);

+ // Test that cues with negative startTime and negative endTime are not added.

+ assert_equals(testTrack.track.cues.length, 4);

+ textCue = new VTTCue(-110, -3.4, "Pepperoni?");

+ testTrack.track.addCue(textCue);

+ assert_equals(testTrack.track.cues.length, 4);

- consoleWrite("<br>Test that cues with negative startTime and negative endTime are not added:");

- testExpected("testTrack.track.cues.length", 4);

- run("textCue = new VTTCue(-110, -3.4, 'Pepperoni?')");

- run("testTrack.track.addCue(textCue)");

- testExpected("testTrack.track.cues.length", 4);

- consoleWrite("<br>Test that setting startTime and endTime to negative values does not affect the value:");

- testExpected("testTrack.track.cues[3].startTime", 121);

- run("testTrack.track.cues[3].startTime = -5");

- testExpected("testTrack.track.cues[3].startTime", 121);

- testExpected("testTrack.track.cues[3].endTime", 361200.5);

- run("testTrack.track.cues[3].endTime = -3439332606");

- testExpected("testTrack.track.cues[3].endTime", 361200.5);

- endTest();

- }

- </script>

- </head>

- <body>

- <p>Tests negative timestamps.</p>

- <video>

- <track id="testTrack" src="captions-webvtt/tc013-settings.vtt" onload="trackLoaded()" default>

- </video>

- </body>

-</html>

+ // Test that setting startTime and endTime to negative values does not affect the value.

+ assert_equals(testTrack.track.cues[3].startTime, 121);

+ testTrack.track.cues[3].startTime = -5;

+ assert_equals(testTrack.track.cues[3].startTime, 121);

+ assert_equals(testTrack.track.cues[3].endTime, 361200.5);

+ testTrack.track.cues[3].endTime = -3439332606;

+ assert_equals(testTrack.track.cues[3].endTime, 361200.5);

+ });

+});

+</script>