Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: tests/FontMgrTest.cpp

Issue 187933002: Fix FontMgrTest to allow for unnamed fonts. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/FontMgrTest.cpp
diff --git a/tests/FontMgrTest.cpp b/tests/FontMgrTest.cpp
index afe618c201668585a7520c7728f01c24495c8313..34fa2d6bfb0fee9b39c6a7383e209a290354ccaa 100644
--- a/tests/FontMgrTest.cpp
+++ b/tests/FontMgrTest.cpp
@@ -47,8 +47,9 @@ static void test_fontiter(skiatest::Reporter* reporter, bool verbose) {
for (int i = 0; i < count; ++i) {
SkString fname;
fm->getFamilyName(i, &fname);
- REPORTER_ASSERT(reporter, fname.size() > 0);
-
+ if (fname.size() == 0) {
bungeman-skia 2014/03/05 18:01:53 Ack! A tab! Do we even need this? Does anything f
hal.canary 2014/03/05 18:24:32 Now that I think about it, the other ASSERTs didn'
+ continue;
+ }
SkAutoTUnref<SkFontStyleSet> fnset(fm->matchFamily(fname.c_str()));
SkAutoTUnref<SkFontStyleSet> set(fm->createStyleSet(i));
REPORTER_ASSERT(reporter, fnset->count() == set->count());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698