Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 187933002: Fix FontMgrTest to allow for unnamed fonts. (Closed)

Created:
6 years, 9 months ago by hal.canary
Modified:
6 years, 9 months ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix FontMgrTest to allow for unnamed fonts. Motivation: we are testing on a system without fonts and are falling back on SkTypeface_Empty. Committed: http://code.google.com/p/skia/source/detail?r=13675

Patch Set 1 #

Total comments: 2

Patch Set 2 : try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tests/FontMgrTest.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
hal.canary
PTAL
6 years, 9 months ago (2014-03-05 17:35:24 UTC) #1
bungeman-skia
https://codereview.chromium.org/187933002/diff/1/tests/FontMgrTest.cpp File tests/FontMgrTest.cpp (right): https://codereview.chromium.org/187933002/diff/1/tests/FontMgrTest.cpp#newcode50 tests/FontMgrTest.cpp:50: if (fname.size() == 0) { Ack! A tab! Do ...
6 years, 9 months ago (2014-03-05 18:01:53 UTC) #2
hal.canary
https://codereview.chromium.org/187933002/diff/1/tests/FontMgrTest.cpp File tests/FontMgrTest.cpp (right): https://codereview.chromium.org/187933002/diff/1/tests/FontMgrTest.cpp#newcode50 tests/FontMgrTest.cpp:50: if (fname.size() == 0) { On 2014/03/05 18:01:53, bungeman1 ...
6 years, 9 months ago (2014-03-05 18:24:32 UTC) #3
bungeman-skia
lgtm
6 years, 9 months ago (2014-03-05 18:25:06 UTC) #4
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 9 months ago (2014-03-05 18:39:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/187933002/180001
6 years, 9 months ago (2014-03-05 18:39:29 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 19:41:12 UTC) #7
Message was sent while issue was closed.
Change committed as 13675

Powered by Google App Engine
This is Rietveld 408576698