Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1879253002: Disable idle suspend for GpuVideoDecoder produced frames on OSX, Win. (Closed)

Created:
4 years, 8 months ago by DaleCurtis
Modified:
4 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable idle suspend for GpuVideoDecoder produced frames on OSX, Win. The hardware decoders on these platforms can not handle being killed while there are outstanding frames. Disable for now. BUG=595716, 602708 . TEST=suspend does not occur on OSX, Windows. Committed: https://crrev.com/7f366b224dbd21f8b8e3d93b3a4635bf68f31977 Cr-Commit-Position: refs/heads/master@{#386881}

Patch Set 1 : Cleanup. #

Total comments: 2

Patch Set 2 : Relocate. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -8 lines) Patch
M media/base/video_frame_metadata.h View 1 chunk +6 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 chunk +7 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 3 chunks +22 lines, -8 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
DaleCurtis
4 years, 8 months ago (2016-04-12 22:37:48 UTC) #3
sandersd (OOO until July 31)
lgtm https://codereview.chromium.org/1879253002/diff/20001/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/1879253002/diff/20001/media/blink/webmediaplayer_impl.cc#newcode1083 media/blink/webmediaplayer_impl.cc:1083: #if defined(OS_MACOSX) || defined(OS_WIN) Move this check into ...
4 years, 8 months ago (2016-04-12 23:19:19 UTC) #4
DaleCurtis
https://codereview.chromium.org/1879253002/diff/20001/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/1879253002/diff/20001/media/blink/webmediaplayer_impl.cc#newcode1083 media/blink/webmediaplayer_impl.cc:1083: #if defined(OS_MACOSX) || defined(OS_WIN) On 2016/04/12 at 23:19:19, sandersd ...
4 years, 8 months ago (2016-04-12 23:33:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879253002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879253002/40001
4 years, 8 months ago (2016-04-12 23:33:51 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 8 months ago (2016-04-13 01:16:26 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 01:17:34 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7f366b224dbd21f8b8e3d93b3a4635bf68f31977
Cr-Commit-Position: refs/heads/master@{#386881}

Powered by Google App Engine
This is Rietveld 408576698