Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1879233009:
Updating build instructions (Closed)
|
Created:
4 years, 8 months ago by brucedawson Modified:
4 years, 8 months ago Reviewers:
dcheng CC:
chromium-reviews, tfarina Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate Windows build instructions for VS 2015
Now that VS 2015 is the only supported compiler this updates the Windows
build instructions to remove all references to VS 2013.
This also adds back the step numbers for steps 3 and 4, which improves
the structure and resolves the dangling references to these steps.
The recommend .sln file to load was changed from all.sln to chrome.sln.
The block indenting for installing VS 2015 was removed. The original
goal was, I believe, to indent that section *and* the Google employees
section. This never happened and the indenting never shows up reasonably
so I'm removing it.
I tested the changes by viewing them at http://dillinger.io/
BUG=440500
Committed: https://crrev.com/c218634e11e3615d61c0c53e3100da7b6468d14d
Cr-Commit-Position: refs/heads/master@{#387652}
Patch Set 1 #Patch Set 2 : Ready for review #
Total comments: 4
Patch Set 3 : Comma to semicolon #Messages
Total messages: 16 (7 generated)
Description was changed from ========== Updating build instructions BUG= ========== to ========== Update Windows build instructions for VS 2015 Now that VS 2015 is the only supported compiler this updates the Windows build instructions to remove all references to VS 2013. This also adds back the step numbers for steps 3 and 4, which improves the structure and resolves the dangling references to these steps. The recommend .sln file to load was changed from all.sln to chrome.sln. The block indenting for installing VS 2015 was removed. The original goal was, I believe, to indent that section *and* the Google employees section. This never happened and the indenting never shows up reasonably so I'm removing it. BUG=440500 ==========
brucedawson@chromium.org changed reviewers: + dcheng@chromium.org
Description was changed from ========== Update Windows build instructions for VS 2015 Now that VS 2015 is the only supported compiler this updates the Windows build instructions to remove all references to VS 2013. This also adds back the step numbers for steps 3 and 4, which improves the structure and resolves the dangling references to these steps. The recommend .sln file to load was changed from all.sln to chrome.sln. The block indenting for installing VS 2015 was removed. The original goal was, I believe, to indent that section *and* the Google employees section. This never happened and the indenting never shows up reasonably so I'm removing it. BUG=440500 ========== to ========== Update Windows build instructions for VS 2015 Now that VS 2015 is the only supported compiler this updates the Windows build instructions to remove all references to VS 2013. This also adds back the step numbers for steps 3 and 4, which improves the structure and resolves the dangling references to these steps. The recommend .sln file to load was changed from all.sln to chrome.sln. The block indenting for installing VS 2015 was removed. The original goal was, I believe, to indent that section *and* the Google employees section. This never happened and the indenting never shows up reasonably so I'm removing it. I tested the changes by viewing them at http://dillinger.io/ BUG=440500 ==========
lgtm https://codereview.chromium.org/1879233009/diff/20001/docs/windows_build_inst... File docs/windows_build_instructions.md (right): https://codereview.chromium.org/1879233009/diff/20001/docs/windows_build_inst... docs/windows_build_instructions.md:11: You must build with Visual Studio 2015 Update 2, no other version is Nit: comma should be a period, colon, or semicolon.
https://codereview.chromium.org/1879233009/diff/20001/docs/windows_build_inst... File docs/windows_build_instructions.md (right): https://codereview.chromium.org/1879233009/diff/20001/docs/windows_build_inst... docs/windows_build_instructions.md:11: You must build with Visual Studio 2015 Update 2, no other version is On 2016/04/15 00:31:13, dcheng wrote: > Nit: comma should be a period, colon, or semicolon. How about a hyphen? "You must build with Visual Studio 2015 Update 2 - no other version is supported."
https://codereview.chromium.org/1879233009/diff/20001/docs/windows_build_inst... File docs/windows_build_instructions.md (right): https://codereview.chromium.org/1879233009/diff/20001/docs/windows_build_inst... docs/windows_build_instructions.md:11: You must build with Visual Studio 2015 Update 2, no other version is On 2016/04/15 at 00:33:06, brucedawson wrote: > On 2016/04/15 00:31:13, dcheng wrote: > > Nit: comma should be a period, colon, or semicolon. > > How about a hyphen? > > "You must build with Visual Studio 2015 Update 2 - no other version is supported." I think it's considered standard to join two independent clauses with a semicolon or colon. Really, this is just a (super minor) nit though.
Thank you for the update! Cheers, Vaclav
https://codereview.chromium.org/1879233009/diff/20001/docs/windows_build_inst... File docs/windows_build_instructions.md (right): https://codereview.chromium.org/1879233009/diff/20001/docs/windows_build_inst... docs/windows_build_instructions.md:11: You must build with Visual Studio 2015 Update 2, no other version is On 2016/04/15 00:50:27, dcheng wrote: > On 2016/04/15 at 00:33:06, brucedawson wrote: > > On 2016/04/15 00:31:13, dcheng wrote: > > > Nit: comma should be a period, colon, or semicolon. > > > > How about a hyphen? > > > > "You must build with Visual Studio 2015 Update 2 - no other version is > supported." > > I think it's considered standard to join two independent clauses with a > semicolon or colon. Really, this is just a (super minor) nit though. My English professor uncle always told me that colons should only be used for shopping lists, so after spending too long reading http://writingcenter.unc.edu/handouts/semi-colons-colons-and-dashes/ I just went with a semi-colon. Any excuse to reference a pendantic writing style article makes me happy.
The CQ bit was checked by brucedawson@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/1879233009/#ps40001 (title: "Comma to semicolon")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879233009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879233009/40001
Message was sent while issue was closed.
Description was changed from ========== Update Windows build instructions for VS 2015 Now that VS 2015 is the only supported compiler this updates the Windows build instructions to remove all references to VS 2013. This also adds back the step numbers for steps 3 and 4, which improves the structure and resolves the dangling references to these steps. The recommend .sln file to load was changed from all.sln to chrome.sln. The block indenting for installing VS 2015 was removed. The original goal was, I believe, to indent that section *and* the Google employees section. This never happened and the indenting never shows up reasonably so I'm removing it. I tested the changes by viewing them at http://dillinger.io/ BUG=440500 ========== to ========== Update Windows build instructions for VS 2015 Now that VS 2015 is the only supported compiler this updates the Windows build instructions to remove all references to VS 2013. This also adds back the step numbers for steps 3 and 4, which improves the structure and resolves the dangling references to these steps. The recommend .sln file to load was changed from all.sln to chrome.sln. The block indenting for installing VS 2015 was removed. The original goal was, I believe, to indent that section *and* the Google employees section. This never happened and the indenting never shows up reasonably so I'm removing it. I tested the changes by viewing them at http://dillinger.io/ BUG=440500 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Update Windows build instructions for VS 2015 Now that VS 2015 is the only supported compiler this updates the Windows build instructions to remove all references to VS 2013. This also adds back the step numbers for steps 3 and 4, which improves the structure and resolves the dangling references to these steps. The recommend .sln file to load was changed from all.sln to chrome.sln. The block indenting for installing VS 2015 was removed. The original goal was, I believe, to indent that section *and* the Google employees section. This never happened and the indenting never shows up reasonably so I'm removing it. I tested the changes by viewing them at http://dillinger.io/ BUG=440500 ========== to ========== Update Windows build instructions for VS 2015 Now that VS 2015 is the only supported compiler this updates the Windows build instructions to remove all references to VS 2013. This also adds back the step numbers for steps 3 and 4, which improves the structure and resolves the dangling references to these steps. The recommend .sln file to load was changed from all.sln to chrome.sln. The block indenting for installing VS 2015 was removed. The original goal was, I believe, to indent that section *and* the Google employees section. This never happened and the indenting never shows up reasonably so I'm removing it. I tested the changes by viewing them at http://dillinger.io/ BUG=440500 Committed: https://crrev.com/c218634e11e3615d61c0c53e3100da7b6468d14d Cr-Commit-Position: refs/heads/master@{#387652} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/c218634e11e3615d61c0c53e3100da7b6468d14d Cr-Commit-Position: refs/heads/master@{#387652} |
