Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1879233002: Move components\profile_service to services\user (Closed)

Created:
4 years, 8 months ago by Ben Goodger (Google)
Modified:
4 years, 8 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move components\profile_service to services\user R=erg@chromium.org BUG= Committed: https://crrev.com/dbc8f978d513b6b01ab33169c0b1d45733dbe861 Cr-Commit-Position: refs/heads/master@{#387125}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -738 lines) Patch
D components/profile_service/BUILD.gn View 1 2 1 chunk +0 lines, -43 lines 0 comments Download
D components/profile_service/DEPS View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D components/profile_service/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D components/profile_service/manifest.json View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D components/profile_service/profile_app.h View 1 2 1 chunk +0 lines, -76 lines 0 comments Download
D components/profile_service/profile_app.cc View 1 2 1 chunk +0 lines, -127 lines 0 comments Download
D components/profile_service/profile_service.gyp View 1 2 1 chunk +0 lines, -95 lines 0 comments Download
D components/profile_service/profile_service_impl.h View 1 2 1 chunk +0 lines, -48 lines 0 comments Download
D components/profile_service/profile_service_impl.cc View 1 2 1 chunk +0 lines, -60 lines 0 comments Download
D components/profile_service/public/cpp/BUILD.gn View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D components/profile_service/public/cpp/constants.h View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
D components/profile_service/public/cpp/constants.cc View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
D components/profile_service/public/interfaces/BUILD.gn View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
D components/profile_service/public/interfaces/profile.mojom View 1 chunk +0 lines, -23 lines 0 comments Download
D components/profile_service/user_id_map.h View 1 chunk +0 lines, -31 lines 0 comments Download
D components/profile_service/user_id_map.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_context.cc View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_wrapper.cc View 1 2 3 6 chunks +12 lines, -12 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_resources.grd View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/public/app/BUILD.gn View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + services/user/BUILD.gn View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
A + services/user/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/user/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/user/manifest.json View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + services/user/public/cpp/BUILD.gn View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A services/user/public/cpp/constants.h View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
A + services/user/public/cpp/constants.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
A + services/user/public/interfaces/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + services/user/public/interfaces/user_service.mojom View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
A + services/user/user.gyp View 1 2 3 4 chunks +19 lines, -19 lines 0 comments Download
A + services/user/user_id_map.h View 1 2 3 1 chunk +11 lines, -11 lines 0 comments Download
A + services/user/user_id_map.cc View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
A + services/user/user_service.h View 1 2 3 3 chunks +12 lines, -12 lines 0 comments Download
A + services/user/user_service.cc View 1 2 3 4 chunks +13 lines, -15 lines 0 comments Download
A + services/user/user_shell_client.h View 1 2 3 3 chunks +20 lines, -27 lines 0 comments Download
A services/user/user_shell_client.cc View 1 2 3 1 chunk +125 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Ben Goodger (Google)
4 years, 8 months ago (2016-04-12 22:49:59 UTC) #1
Elliot Glaysher
I DEMAND //THINGS/. ... (lgtm)
4 years, 8 months ago (2016-04-13 17:33:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879233002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879233002/40001
4 years, 8 months ago (2016-04-13 19:35:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/50360)
4 years, 8 months ago (2016-04-13 19:47:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1879233002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1879233002/60001
4 years, 8 months ago (2016-04-13 20:31:32 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-13 22:29:43 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 22:31:27 UTC) #13
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/dbc8f978d513b6b01ab33169c0b1d45733dbe861
Cr-Commit-Position: refs/heads/master@{#387125}

Powered by Google App Engine
This is Rietveld 408576698