Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 187923006: Renderer context menu: add missing search provider link. (Closed)

Created:
6 years, 9 months ago by lazyboy
Modified:
6 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Renderer context menu: add missing search provider link. I created a group for this item in r254287, but forgot to add it in render_view_context_menu.cc. BUG=348379 Test=Select some <text> in webpage, right click to see context menu, "Search Google for <text>" should appear in the list now. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255267

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/renderer_context_menu/context_menu_content_type_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
lazyboy
6 years, 9 months ago (2014-03-05 19:55:44 UTC) #1
Avi (use Gerrit)
Ooops :) LGTM
6 years, 9 months ago (2014-03-05 20:04:24 UTC) #2
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 9 months ago (2014-03-05 20:14:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/187923006/20001
6 years, 9 months ago (2014-03-05 20:15:10 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 21:40:51 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275609
6 years, 9 months ago (2014-03-05 21:40:51 UTC) #6
lazyboy
The CQ bit was checked by lazyboy@chromium.org
6 years, 9 months ago (2014-03-05 21:48:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/187923006/20001
6 years, 9 months ago (2014-03-05 21:51:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/187923006/20001
6 years, 9 months ago (2014-03-06 00:03:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/187923006/20001
6 years, 9 months ago (2014-03-06 02:43:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/187923006/20001
6 years, 9 months ago (2014-03-06 03:12:34 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 05:49:18 UTC) #12
Message was sent while issue was closed.
Change committed as 255267

Powered by Google App Engine
This is Rietveld 408576698